[Tab Metrics] Measure FP, FCP and FMP for Foreground Tab during Session Restore

chrome/browser/sessions/session_restore.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_SESSION_RESTORE_H_
 #define CHROME_BROWSER_SESSIONS_SESSION_RESTORE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 104 matching lines @@
 
  private:
   friend class SessionRestoreImpl;
   FRIEND_TEST_ALL_PREFIXES(SessionRestoreObserverTest, SingleSessionRestore);
   FRIEND_TEST_ALL_PREFIXES(SessionRestoreObserverTest,
                            SequentialSessionRestores);
   FRIEND_TEST_ALL_PREFIXES(SessionRestoreObserverTest,
                            ConcurrentSessionRestores);
   FRIEND_TEST_ALL_PREFIXES(SessionRestoreObserverTest,
                            TabManagerShouldObserveSessionRestore);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,

[Bryan McQuade, 2017/08/09 15:41:35]

eek, it's slightly concerning to me that we need to call private methods from
tests - it's usually a hint that we may not be testing the real production
behavior directly. is this standard practice for session restore tests? i don't
know the code well enough to make a firm call here, but this is slightly
worrying to me.

[ducbui, 2017/08/09 19:43:07]

I will remove these because OnWillRestoreTab() is made public in a
related CL (https://chromium-review.googlesource.com/c/601545).

+                           RestoreSingleForegroundTab);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,
+                           RestoreMultipleForegroundTabs);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,
+                           RestoreBackgroundTab);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,
+                           HideTabBeforeFirstPaints);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,
+                           SwitchInitialRestoredForegroundTab);
+  FRIEND_TEST_ALL_PREFIXES(SessionRestorePageLoadMetricsObserverTest,
+                           MultipleSessionRestores);
 
   // Session restore observer list.
   using SessionRestoreObserverList = base::ObserverList<SessionRestoreObserver>;
 
   SessionRestore();
 
   // Accessor for |*on_session_restored_callbacks_|. Creates a new object the
   // first time so that it always returns a valid object.
   static CallbackList* on_session_restored_callbacks() {
     if (!on_session_restored_callbacks_)
@@ skipping 23 matching lines @@
   // Contains all registered observers for session restore events.
   static SessionRestoreObserverList* observers_;
 
   // Whether session restore started or not.
   static bool session_restore_started_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionRestore);
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_SESSION_RESTORE_H_