Issue 2930003002: Bind the diagnostics server on ipv4 ports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2930003002: Bind the diagnostics server on ipv4 ports. (Closed)

Created:
3 years, 6 months ago by devoncarew

Modified:
3 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Bind the diagnostics server on ipv4 ports. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/64af69ac5154aad36037b3e3d79481b1dae6f169

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/server/http_server.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/pkg.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

devoncarew

Revert part of https://codereview.chromium.org/2927783002/ (don't bind the diagnostic server to ipv6 ports). Fix https://github.com/dart-lang/sdk/issues/29820.

3 years, 6 months ago (2017-06-09 05:37:40 UTC) #2

devoncarew

3 years, 6 months ago (2017-06-09 17:43:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
64af69ac5154aad36037b3e3d79481b1dae6f169 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages