Make profile error dialog async

chrome/browser/ui/android/simple_message_box_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/simple_message_box.h"
 
+#include <utility>
+
 #include "base/logging.h"
 
 namespace chrome {
 
 void ShowWarningMessageBox(gfx::NativeWindow parent,
                            const base::string16& title,
                            const base::string16& message) {
   NOTIMPLEMENTED();
 }
 
 MessageBoxResult ShowQuestionMessageBox(gfx::NativeWindow parent,
                                         const base::string16& title,
                                         const base::string16& message) {
   NOTIMPLEMENTED();
   return MESSAGE_BOX_RESULT_NO;
 }
 
-bool ShowWarningMessageBoxWithCheckbox(gfx::NativeWindow parent,
-                                       const base::string16& title,
-                                       const base::string16& message,
-                                       const base::string16& checkbox_text) {
+void ShowWarningMessageBoxWithCheckbox(
+    gfx::NativeWindow parent,
+    const base::string16& title,
+    const base::string16& message,
+    const base::string16& checkbox_text,
+    base::OnceCallback<void(bool checked)> callback) {
   NOTIMPLEMENTED();
-  return false;
+  std::move(callback).Run(false);

[Peter Kasting, 2017/06/12 23:54:19]

I don't understand the function of std::move() in this statement.  It converts
an lvalue to an rvalue, but I don't know why that matters.

This confusion holds for the other files in this CL as well.

[xiyuan, 2017/06/13 21:49:44]

That is the current syntax to run a OnceClosure/OnceCallback. Doc here [1]. And
one example in [2].

[1]:
https://cs.chromium.org/chromium/src/docs/callback.md?rcl=762bb48da4b3ff06e5a...

[2]:
https://cs.chromium.org/chromium/src/base/barrier_closure.cc?rcl=eaa976b4923b...

[Peter Kasting, 2017/06/14 00:28:55]

This doc doesn't really make any note of the move() call and why it's there,
though.  Do things not compile without it?  Is it just trying to explicitly
state to readers "be aware that .Run() will mutate this"?  I'd really like this
to be clearer about if this is "preferred" or "necessary", and in either case
why.

Doesn't have to be fixed in this CL, unless you aren't sure of the answer either
and the code compiles without this, in which case I would hit the pause button
here until we can get a definitive answer.  If you're sure this is needed, then
proceed, but try to update the docs separately.

 }
 
 }  // namespace chrome