Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: src/hydrogen-load-elimination.cc

Issue 292993003: Revert "Refactor transitioning stores." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/hydrogen-store-elimination.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-load-elimination.cc
diff --git a/src/hydrogen-load-elimination.cc b/src/hydrogen-load-elimination.cc
index 6967630b57cd4e25c8ddf27ae65e483845821996..1198d2b7ab59afeb6318745c0cf45fcf440138bf 100644
--- a/src/hydrogen-load-elimination.cc
+++ b/src/hydrogen-load-elimination.cc
@@ -240,7 +240,12 @@ class HLoadEliminationTable : public ZoneObject {
HValue* object = instr->object()->ActualValue();
HValue* value = instr->value();
- if (instr->store_mode() == STORE_TO_INITIALIZED_ENTRY) {
+ if (instr->has_transition()) {
+ // A transition introduces a new field and alters the map of the object.
+ // Since the field in the object is new, it cannot alias existing entries.
+ // TODO(titzer): introduce a constant for the new map and remember it.
+ KillFieldInternal(object, FieldOf(JSObject::kMapOffset), NULL);
+ } else {
// Kill non-equivalent may-alias entries.
KillFieldInternal(object, field, value);
}
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/hydrogen-store-elimination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698