services/resource_coordinator/coordination_unit/coordination_unit_impl.h - Issue 2929883002: [GRC] ResourceCoordinatorInterface support to remove children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_impl.h

Issue 2929883002: [GRC] ResourceCoordinatorInterface support to remove children (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | services/resource_coordinator/coordination_unit/coordination_unit_impl.cc » ('j') | services/resource_coordinator/coordination_unit/coordination_unit_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/coordination_unit/coordination_unit_impl.h

diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h

index 447b1afae980679db6c2411c0930b7cf887ce220..d8b3fe24fdb9721d8bb51e73513408e58d5bc720 100644

--- a/services/resource_coordinator/coordination_unit/coordination_unit_impl.h

+++ b/services/resource_coordinator/coordination_unit/coordination_unit_impl.h

@@ -35,6 +35,7 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {

void GetID(const GetIDCallback& callback) override;

void AddBinding(mojom::CoordinationUnitRequest request) override;

void AddChild(const CoordinationUnitID& child_id) override;

+ void RemoveChild(const CoordinationUnitID& child_id) override;

void SetCoordinationPolicyCallback(

mojom::CoordinationPolicyCallbackPtr callback) override;

void SetProperty(mojom::PropertyPtr property) override;

@@ -65,7 +66,7 @@ class CoordinationUnitImpl : public mojom::CoordinationUnit {

private:

bool AddChild(CoordinationUnitImpl* child);

- void RemoveChild(CoordinationUnitImpl* child);

+ bool RemoveChild(CoordinationUnitImpl* child);

void AddParent(CoordinationUnitImpl* parent);

void RemoveParent(CoordinationUnitImpl* parent);

bool HasParent(CoordinationUnitImpl* unit);