Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2929853003: Fix use of history timers in background threads. (Closed)
Patch Set: Fix nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index 41370c6adb06647e4bb1793b286471846a572eba..5fc178d3b6997eda80792f60edbbf9c1045f1397 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -4012,18 +4012,8 @@ void WasmCompilationUnit::InitializeHandles() {
void WasmCompilationUnit::ExecuteCompilation() {
DCHECK(handles_initialized_);
- if (is_sync_) {
- // TODO(karlschimpf): Make this work when asynchronous.
- // https://bugs.chromium.org/p/v8/issues/detail?id=6361
- HistogramTimerScope wasm_compile_function_time_scope(
- isolate_->counters()->wasm_compile_function_time());
- ExecuteCompilationInternal();
- return;
- }
- ExecuteCompilationInternal();
-}
-
-void WasmCompilationUnit::ExecuteCompilationInternal() {
+ TimedHistogramScope wasm_compile_function_time_scope(
+ isolate_->counters()->wasm_compile_function_time());
if (FLAG_trace_wasm_compiler) {
if (func_name_.start() != nullptr) {
PrintF("Compiling WASM function %d:'%.*s'\n\n", func_index(),
« no previous file with comments | « src/compiler/wasm-compiler.h ('k') | src/counters.h » ('j') | src/wasm/module-compiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698