src/isolate.cc - Issue 2929853003: Fix use of history timers in background threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2929853003: Fix use of history timers in background threads. (Closed)

Patch Set: Make explicit when async_counters is needed. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 2e6a38b6aecedda421e719f0f120e08f0499a28b..f11b3f1adae5594dc872a22d11795851b9d8624f 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2631,8 +2631,8 @@ bool Isolate::PropagatePendingExceptionToExternalTryCatch() {

}

bool Isolate::InitializeCounters() {

- if (counters_shared_) return false;

- counters_shared_ = std::make_shared<Counters>(this);

+ if (async_counters_) return false;

+ async_counters_ = std::make_shared<Counters>(this);

return true;

}

« no previous file with comments | « src/isolate.h ('k') | src/wasm/module-compiler.h » ('j') | no next file with comments »