Fix use of history timers in background threads.

src/wasm/module-compiler.cc

 // Copyright 2017 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <src/wasm/module-compiler.h>
 
 #include <src/counters.h>
 #include "src/asmjs/asm-js.h"
 #include "src/assembler-inl.h"
 #include "src/property-descriptor.h"
@@ skipping 304 matching lines @@
   Handle<FixedArray> function_tables =
       factory->NewFixedArray(function_table_count, TENURED);
   Handle<FixedArray> signature_tables =
       factory->NewFixedArray(function_table_count, TENURED);
   for (int i = 0; i < function_table_count; ++i) {
     temp_instance.function_tables[i] = factory->NewFixedArray(1, TENURED);
     temp_instance.signature_tables[i] = factory->NewFixedArray(1, TENURED);
     function_tables->set(i, *temp_instance.function_tables[i]);
     signature_tables->set(i, *temp_instance.signature_tables[i]);
   }
-
-  if (is_sync_) {
-    // TODO(karlschimpf): Make this work when asynchronous.
-    // https://bugs.chromium.org/p/v8/issues/detail?id=6361
-    HistogramTimerScope wasm_compile_module_time_scope(
-        module_->is_wasm()
-            ? isolate_->counters()->wasm_compile_wasm_module_time()
-            : isolate_->counters()->wasm_compile_asm_module_time());
-    return CompileToModuleObjectInternal(
-        thrower, wire_bytes, asm_js_script, asm_js_offset_table_bytes, factory,
-        &temp_instance, &function_tables, &signature_tables);
-  }
+  TimedHistogramScope wasm_compile_module_time_scope(
+      module_->is_wasm()
+          ? isolate_->counters()->wasm_compile_wasm_module_time()

[jochen (gone - plz use gerrit), 2017/06/08 22:15:36]

you can't access isolate_ if !is_sync

[kschimpf, 2017/06/09 20:03:36]

Your right.

+          : isolate_->counters()->wasm_compile_asm_module_time());
   return CompileToModuleObjectInternal(
       thrower, wire_bytes, asm_js_script, asm_js_offset_table_bytes, factory,
       &temp_instance, &function_tables, &signature_tables);
 }
 
 namespace {
 bool compile_lazy(const WasmModule* module) {
   return FLAG_wasm_lazy_compilation ||
          (FLAG_asm_wasm_lazy_compilation && module->is_asm_js());
 }
@@ skipping 1960 matching lines @@
     HandleScope scope(job_->isolate_);
     Handle<WasmModuleObject> result =
         WasmModuleObject::New(job_->isolate_, job_->compiled_module_);
     // {job_} is deleted in AsyncCompileSucceeded, therefore the {return}.
     return job_->AsyncCompileSucceeded(result);
   }
 };
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8