Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 292983014: Fixed some problems with tools. (Closed)

Created:
6 years, 7 months ago by bcwhite
Modified:
6 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed some problems with tools. - "cd" under some bash settings can print the current directory - adb_gdb variable use is missing undescore BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272686

Patch Set 1 #

Patch Set 2 : removed mistakenly added file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/adb_gdb View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bcwhite
Not sure who should review and approve this; looks like anybody can.
6 years, 7 months ago (2014-05-22 16:52:37 UTC) #1
aurimas (slooooooooow)
lgtm
6 years, 7 months ago (2014-05-22 21:14:52 UTC) #2
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 7 months ago (2014-05-23 12:42:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/292983014/20001
6 years, 7 months ago (2014-05-23 12:42:51 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 02:34:43 UTC) #5
Message was sent while issue was closed.
Change committed as 272686

Powered by Google App Engine
This is Rietveld 408576698