Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 292983003: Use different Access Point on iOS for phone and tablet (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use different Access Point on iOS for phone and tablet Introduce an accessor for the value of the access point since it is no longer a constant for the platform but may depends on conditions that are only known at runtime (difference between phone and tablet on iOS). Chrome on iOS will use the access point C9 and CD for tracking usage of the omnibox on tablet and phone respectively. BUG=375170 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -110 lines) Patch
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/rlz/rlz.cc View 17 chunks +26 lines, -62 lines 0 comments Download
A chrome/browser/rlz/rlz_chromeos.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/rlz/rlz_ios.mm View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/rlz/rlz_mac.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 6 chunks +30 lines, -28 lines 0 comments Download
A chrome/browser/rlz/rlz_win.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/search_terms_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M rlz/lib/lib_values.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M rlz/lib/rlz_enums.h View 1 chunk +3 lines, -2 lines 0 comments Download
M rlz/lib/rlz_lib.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sdefresne
rogerta: chrome/browser/rlz & rlz/, please review the API change that are required due to the ...
6 years, 7 months ago (2014-05-20 16:32:34 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 7 months ago (2014-05-20 19:06:49 UTC) #2
Nico
lgtm
6 years, 7 months ago (2014-05-20 21:52:48 UTC) #3
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-21 07:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/292983003/1
6 years, 7 months ago (2014-05-21 07:54:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:28:52 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 06:47:52 UTC) #7
Message was sent while issue was closed.
Change committed as 272124

Powered by Google App Engine
This is Rietveld 408576698