Making AudioManagerBase::ShutdownOnAudioThread() platform-agnostic

media/audio/mac/audio_manager_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_manager_mac.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 511 matching lines @@
                             base::Unretained(this)));
 }
 
 AudioManagerMac::~AudioManagerMac() = default;
 
 void AudioManagerMac::ShutdownOnAudioThread() {
   // We are now in shutdown mode. This flag disables MaybeChangeBufferSize()
   // and IncreaseIOBufferSizeIfPossible() which both touches native Core Audio
   // APIs and they can fail and disrupt tests during shutdown.
   in_shutdown_ = true;
   AudioManagerBase::ShutdownOnAudioThread();

[alokp, 2017/07/14 18:58:53]

nit: May be release base class resources *after* local resources to be
consistent with the ways destructors work?

+
+  // Even if tasks to close the streams are enqueued, they would not run
+  // leading to CHECKs getting hit in the destructor about open streams. Close
+  // them explicitly here. crbug.com/608049.
+  for (auto iter = basic_input_streams_.begin();
+       iter != basic_input_streams_.end();) {
+    // Note: Closing the stream will invalidate the iterator.
+    // Increment the iterator before closing the stream.
+    AudioInputStream* stream = *iter++;
+    stream->Close();
+  }
+  for (auto iter = low_latency_input_streams_.begin();
+       iter != low_latency_input_streams_.end();) {
+    // Note: Closing the stream will invalidate the iterator.
+    // Increment the iterator before closing the stream.
+    AudioInputStream* stream = *iter++;
+    stream->Close();
+  }
+  CHECK(basic_input_streams_.empty());
+  CHECK(low_latency_input_streams_.empty());
 }
 
 bool AudioManagerMac::HasAudioOutputDevices() {
   return HasAudioHardware(kAudioHardwarePropertyDefaultOutputDevice);
 }
 
 bool AudioManagerMac::HasAudioInputDevices() {
   return HasAudioHardware(kAudioHardwarePropertyDefaultInputDevice);
 }
 
@@ skipping 635 matching lines @@
 }
 
 std::unique_ptr<AudioManager> CreateAudioManager(
     std::unique_ptr<AudioThread> audio_thread,
     AudioLogFactory* audio_log_factory) {
   return base::MakeUnique<AudioManagerMac>(std::move(audio_thread),
                                            audio_log_factory);
 }
 
 }  // namespace media