Mac: Remove create_application_shortcut_cocoa.mm

chrome/app/generated_resources.grd

 <?xml version="1.0" encoding="utf-8"?>
 
 <!--
 This file contains definitions of resources that will be translated for each
 locale.  The variables is_win, is_macosx, is_linux, and is_posix are available
 for making strings OS specific.  Other platform defines such as use_titlecase
 are declared in build/common.gypi.
 -->
 
 <grit base_dir="." latest_public_release="0" current_release="1"
@@ skipping 1973 matching lines @@
         </message>
         <message name="IDS_APPLICATION_INFO_LICENSES_BUTTON_TEXT" desc="In Title Case: Text for the button that displays the licenses for the app or extension.">
           Licenses
         </message>
         <message name="IDS_APPLICATION_INFO_SIZE_LABEL" desc="In Title Case: Text displayed before the app or extension's size on disk in the details section of the dialog.">
           Size:
         </message>
         <message name="IDS_APPLICATION_INFO_VERSION_LABEL" desc="In Title Case: Text displayed before the app or extension's version in the details section of the dialog.">
           Version:
         </message>
-        <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that opens the dialog to create shortcuts for the app.">
+        <if expr="is_macosx">
+          <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that creates a shortcut for the app.">
+            Create Shortcut
+          </message>
+        </if>
+        <if expr="not is_macosx">
+          <message name="IDS_APPLICATION_INFO_CREATE_SHORTCUTS_BUTTON_TEXT" desc="In Title Case: Text for the button that opens the dialog to create shortcuts for the app.">
           Create Shortcuts...
-        </message>
+          </message>
+        </if>
       </if>
       <message name="IDS_APPLICATION_INFO_SIZE_LOADING_LABEL" desc="Text displayed instead of the app or extension's size on disk in the details section of the dialog while the size is being calculated.">
         Calculating...
       </message>
       <message name="IDS_APPLICATION_INFO_SIZE_SMALL_LABEL" desc="Text displayed instead of the app or extension's size for apps and extensions that are less than 1 megabyte in size.">
         &lt; 1 MB
       </message>
       <message name="IDS_APPLICATION_INFO_REVOKE_PERMISSION_ALT_TEXT" desc="Alt text displayed on hover (or in a screen reader) on the icon button that revokes (removes) the permission from this app.">
         Revoke the permission '<ph name="PERMISSION">$1<ex>Access your USB and Bluetooth devices</ex></ph>'
       </message>
@@ skipping 10 matching lines @@
            other {Access # files stored on your computer}}
       </message>
 
       <message name="IDS_APPLICATION_INFO_RETAINED_DEVICES" desc="A line of explanatory text that precedes the list of USB devices the app has permanent access to, showing the number of USB devices. This is shown when an app has persistent access to USB devices. [ICU Syntax]">
         {NUM_DEVICES, plural,
          =1 {Communicate with a USB device}
          other {Communicate with # USB devices}}
       </message>
 
       <!-- "Create application shortcuts" dialog -->
-      <if expr="not use_titlecase">
-        <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="Title of the dialog to create application shortcuts for current page.">
-          Create application shortcuts
+      <if expr="not is_macosx">
+        <if expr="not use_titlecase">
+          <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="Title of the dialog to create application shortcuts for current page.">
+            Create application shortcuts
+          </message>
+        </if>
+        <if expr="use_titlecase">
+          <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="In Title Case: title of the dialog to create application shortcuts for current page.">
+            Create Application Shortcuts
+          </message>
+        </if>
+        <message name="IDS_CREATE_SHORTCUTS_LABEL" desc="Contents of the main label in the create application shortcuts dialog explaining the dialog.">
+          Add shortcuts to the following places:
         </message>
-      </if>
-      <if expr="use_titlecase">
-        <message name="IDS_CREATE_SHORTCUTS_TITLE" desc="In Title Case: title of the dialog to create application shortcuts for current page.">
-          Create Application Shortcuts
+        <message name="IDS_CREATE_SHORTCUTS_DESKTOP_CHKBOX" desc="Label of the checkbox to create an application shortcut on the desktop.">
+          Desktop
         </message>
-      </if>
-      <message name="IDS_CREATE_SHORTCUTS_LABEL" desc="Contents of the main label in the create application shortcuts dialog explaining the dialog.">
-        Add shortcuts to the following places:
-      </message>
-      <message name="IDS_CREATE_SHORTCUTS_DESKTOP_CHKBOX" desc="Label of the checkbox to create an application shortcut on the desktop.">
-        Desktop
-      </message>
-      <message name="IDS_CREATE_SHORTCUTS_MENU_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications menu.">
-        Applications menu
-      </message>
-      <if expr="is_macosx">
-        <message name="IDS_CREATE_SHORTCUTS_APP_FOLDER_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications folder.">
-          Applications folder
+        <message name="IDS_CREATE_SHORTCUTS_MENU_CHKBOX" desc="Label of the checkbox to create an application shortcut in the system's applications menu.">
+          Applications menu
+        </message>
+        <message name="IDS_CREATE_SHORTCUTS_COMMIT" desc="Title of the button to actually create the shortcuts.">
+          Create
         </message>
       </if>

[tapted, 2017/06/09 01:15:33]

the diff came out a bit confusing..
summary: the "if" block that ends here is `expr="not is_macosx"` - I moved
IDS_CREATE_SHORTCUTS_COMMIT from below into it and indented the rest

       <if expr="is_win">
         <message name="IDS_CREATE_SHORTCUTS_START_MENU_CHKBOX" desc="Label of the checkbox to create an application shortcut in the start menu.">
           Start menu
         </message>
         <message name="IDS_CREATE_SHORTCUTS_QUICK_LAUNCH_BAR_CHKBOX" desc="Label of the checkbox to create an application shortcut in quick launch bar.">
           Quick launch bar
         </message>
         <message name="IDS_PIN_TO_TASKBAR_CHKBOX" desc="Label of the checkbox to pin an application shortcut to taskbar.">
           Pin to Taskbar
         </message>
       </if>
-      <message name="IDS_CREATE_SHORTCUTS_COMMIT" desc="Title of the button to actually create the shortcuts.">
-        Create
-      </message>
 
       <!-- Web Share Target picker dialog -->
       <if expr="not use_titlecase">
         <message name="IDS_WEBSHARE_TARGET_PICKER_TITLE" desc="Title of the dialog to choose a target for sharing.">
           Share via
         </message>
       </if>
       <if expr="use_titlecase">
         <message name="IDS_WEBSHARE_TARGET_PICKER_TITLE" desc="Title of the dialog to choose a target for sharing.">
           Share Via
@@ skipping 6309 matching lines @@
 
       <if expr="not use_titlecase">
         <message name="IDS_NEW_TAB_APP_OPTIONS"
                  desc="Text for the context menu item that takes the user to the options of an app. (In sentence case.)">
           Options
         </message>
         <message name="IDS_NEW_TAB_APP_DETAILS"
                  desc="Text for the context menu item that takes the user to the app in Web Store. (In sentence case.)">
           View in Web Store
         </message>
-        <if expr="is_macosx">
-          <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
-                   desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
-            Create shortcut...
-          </message>
-        </if>
-        <if expr="not is_macosx">
-          <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
-                   desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
-            Create shortcuts...
-          </message>
-        </if>
+        <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
+                 desc="Text for the context menu item that creates an app shortcut. (In sentence case.)">
+          Create shortcuts...
+        </message>

[tapted, 2017/06/09 01:15:33]

note the old `if expr="is_macosx"` would never have been used since
use_titlecase is always true on mac 

         <message name="IDS_APP_CONTEXT_MENU_SHOW_INFO"
                  desc="Text for the context menu item that shows the application information. (In sentence case.)">
           App info
         </message>
         <message name="IDS_APP_CONTEXT_MENU_OPEN_PINNED"
                  desc="Text for the button that opens the app in a pinned tab. (In sentence case.)">
           Open as pinned tab
         </message>
         <message name="IDS_APP_CONTEXT_MENU_OPEN_REGULAR"
                  desc="Text for the button that opens the app in a regular tab. (In sentence case.)">
@@ skipping 28 matching lines @@
                  desc="Text for the context menu item that takes the user to the options of an app. (In title case.)">
           Options
         </message>
         <message name="IDS_NEW_TAB_APP_DETAILS"
                  desc="Text for the context menu item that takes the user to the app in Web Store. (In title case.)">
           View in Web Store
         </message>
         <if expr="is_macosx">
           <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
                    desc="Text for the context menu item that creates an app shortcut. (In title case.)">
-            Create Shortcut...
+            Create Shortcut
           </message>
         </if>
         <if expr="not is_macosx">
           <message name="IDS_NEW_TAB_APP_CREATE_SHORTCUT"
                    desc="Text for the context menu item that creates an app shortcut. (In title case.)">
             Create Shortcuts...
           </message>
         </if>
         <message name="IDS_APP_CONTEXT_MENU_SHOW_INFO"
                  desc="Text for the context menu item that shows the application information. (In title case.)">
@@ skipping 3859 matching lines @@
       <message name="IDS_VIDEO_AUDIO_CALL_NOTIFICATION_TEXT_2" desc="Text to be shown as a notification when a WebRTC video and audio call is in progress" formatter_data="android_java">
         Accessing audio and video input
       </message>
       <message name="IDS_SCREEN_CAPTURE_NOTIFICATION_TEXT_2" desc="Text to be shown as a notification when screen capture is in progress.">
         Sharing screen
       </message>
     </if>
   </messages>
  </release>
 </grit>