Flag-file added for rollback reset option.

Flag-file added for rollback reset option.

As far as update engine that process Rollback requests requires rootfs verification, we're unable to set usual flag for testing Rollback option.

So existence of /tmp/.enable_rollback_ui file is the new flag for Rollback reset option.

BUG=368860
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272840

[merkulova, 2014-05-22 08:24:13]

Should I remove usual flag (chromeos_switches) as unused?

[Nikita (slow), 2014-05-22 09:48:32]

On 2014/05/22 08:24:13, merkulova wrote:
> Should I remove usual flag (chromeos_switches) as unused?

I would recommend leaving the flag since it maybe added to the
session_manager_setup.sh for testing and flag file needs to be recreated on each
reboot.

[Nikita (slow), 2014-05-22 09:51:31]

lgtm

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right):

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:44: static const
char kRollbackFlagFile[] = "/tmp/enable_rollback_ui.flag";
nit: /tmp/.enable_rollback_ui

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:133: FROM_HERE,
nit: 4 spaces indent

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:159: 
nit: drop extra empty line

[merkulova, 2014-05-22 11:22:01]

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right):

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:44: static const
char kRollbackFlagFile[] = "/tmp/enable_rollback_ui.flag";
On 2014/05/22 09:51:32, Nikita Kostylev wrote:
> nit: /tmp/.enable_rollback_ui

Done.

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:133: FROM_HERE,
On 2014/05/22 09:51:32, Nikita Kostylev wrote:
> nit: 4 spaces indent

Done.

https://codereview.chromium.org/292973005/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:159: 
On 2014/05/22 09:51:32, Nikita Kostylev wrote:
> nit: drop extra empty line

Done.

[merkulova, 2014-05-25 18:16:54]

Sending to CQ so that canary is available soon for testing.

[merkulova, 2014-05-25 18:16:57]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-25 18:17:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/292973005/20001

[commit-bot: I haz the power, 2014-05-25 20:13:11]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-25 20:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 20:17:57]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[merkulova, 2014-05-25 22:16:59]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-05-25 22:17:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/292973005/20001

[commit-bot: I haz the power, 2014-05-25 22:23:35]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-25 22:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 22:46:17]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[Nikita (slow), 2014-05-26 08:45:44]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-05-26 08:46:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/292973005/20001

[commit-bot: I haz the power, 2014-05-26 09:10:05]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)

[commit-bot: I haz the power, 2014-05-26 16:15:47]

Change committed as 272840