Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: base/trace_event/memory_tracing_observer.cc

Issue 2929673005: Code cleanup and typos in trace_event [NFC] (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/trace_event/memory_peak_detector.h ('k') | base/trace_event/trace_category.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/trace_event/memory_tracing_observer.h" 5 #include "base/trace_event/memory_tracing_observer.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/trace_event/memory_dump_manager.h" 8 #include "base/trace_event/memory_dump_manager.h"
9 #include "base/trace_event/trace_event_argument.h" 9 #include "base/trace_event/trace_event_argument.h"
10 10
(...skipping 13 matching lines...) Expand all
24 return enabled; 24 return enabled;
25 } 25 }
26 26
27 }; // namespace 27 }; // namespace
28 28
29 MemoryTracingObserver::MemoryTracingObserver( 29 MemoryTracingObserver::MemoryTracingObserver(
30 TraceLog* trace_log, 30 TraceLog* trace_log,
31 MemoryDumpManager* memory_dump_manager) 31 MemoryDumpManager* memory_dump_manager)
32 : memory_dump_manager_(memory_dump_manager), trace_log_(trace_log) { 32 : memory_dump_manager_(memory_dump_manager), trace_log_(trace_log) {
33 // If tracing was enabled before initializing MemoryDumpManager, we missed the 33 // If tracing was enabled before initializing MemoryDumpManager, we missed the
34 // OnTraceLogEnabled() event. Synthetize it so we can late-join the party. 34 // OnTraceLogEnabled() event. Synthesize it so we can late-join the party.
35 // IsEnabled is called before adding observer to avoid calling 35 // IsEnabled is called before adding observer to avoid calling
36 // OnTraceLogEnabled twice. 36 // OnTraceLogEnabled twice.
37 bool is_tracing_already_enabled = trace_log_->IsEnabled(); 37 bool is_tracing_already_enabled = trace_log_->IsEnabled();
38 trace_log_->AddEnabledStateObserver(this); 38 trace_log_->AddEnabledStateObserver(this);
39 if (is_tracing_already_enabled) 39 if (is_tracing_already_enabled)
40 OnTraceLogEnabled(); 40 OnTraceLogEnabled();
41 } 41 }
42 42
43 MemoryTracingObserver::~MemoryTracingObserver() { 43 MemoryTracingObserver::~MemoryTracingObserver() {
44 trace_log_->RemoveEnabledStateObserver(this); 44 trace_log_->RemoveEnabledStateObserver(this);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 bool MemoryTracingObserver::IsDumpModeAllowed( 107 bool MemoryTracingObserver::IsDumpModeAllowed(
108 MemoryDumpLevelOfDetail dump_mode) const { 108 MemoryDumpLevelOfDetail dump_mode) const {
109 if (!memory_dump_config_) 109 if (!memory_dump_config_)
110 return false; 110 return false;
111 return memory_dump_config_->allowed_dump_modes.count(dump_mode) != 0; 111 return memory_dump_config_->allowed_dump_modes.count(dump_mode) != 0;
112 } 112 }
113 113
114 } // namespace trace_event 114 } // namespace trace_event
115 } // namespace base 115 } // namespace base
OLDNEW
« no previous file with comments | « base/trace_event/memory_peak_detector.h ('k') | base/trace_event/trace_category.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698