Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: remoting/ios/app/host_collection_view_cell.mm

Issue 2929663002: [CRD iOS] Fix color scheme and other UI issues (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/ios/app/host_collection_view_cell.mm
diff --git a/remoting/ios/app/host_collection_view_cell.mm b/remoting/ios/app/host_collection_view_cell.mm
index 1b8c33db1f357e5ebc9503cd789881fb39084c98..2029e61c146692f6acb4a6136fae4200138b27a4 100644
--- a/remoting/ios/app/host_collection_view_cell.mm
+++ b/remoting/ios/app/host_collection_view_cell.mm
@@ -11,6 +11,7 @@
#import "remoting/ios/app/host_collection_view_cell.h"
#import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
+#import "remoting/ios/app/remoting_styles.h"
#import "remoting/ios/domain/host_info.h"
static const CGFloat kLinePadding = 2.f;
@@ -49,7 +50,7 @@ static const CGFloat kHostCardIconSize = 45.f;
_imageView.translatesAutoresizingMaskIntoConstraints = NO;
_imageView.contentMode = UIViewContentModeCenter;
_imageView.alpha = 0.87f;
- _imageView.backgroundColor = UIColor.lightGrayColor;
+ _imageView.backgroundColor = RemotingStyles.offlineHostColor;
_imageView.layer.cornerRadius = kHostCardIconSize / 2.f;
_imageView.layer.masksToBounds = YES;
[self.contentView addSubview:_imageView];
@@ -131,13 +132,11 @@ static const CGFloat kHostCardIconSize = 45.f;
_imageView.image = [UIImage imageNamed:@"ic_desktop"];
- // TODO(nicholss): These colors are incorrect for the final product.
- // Need to update to the values in the mocks.
if ([_hostInfo.status isEqualToString:@"ONLINE"]) {
- _imageView.backgroundColor = UIColor.greenColor;
+ _imageView.backgroundColor = RemotingStyles.onlineHostColor;
_statusLabel.text = @"Online";
} else {
- _imageView.backgroundColor = UIColor.lightGrayColor;
+ _imageView.backgroundColor = RemotingStyles.offlineHostColor;
_statusLabel.text =
[NSString stringWithFormat:@"Last online: %@", hostInfo.updatedTime];
}

Powered by Google App Engine
This is Rietveld 408576698