ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.h - Issue 2929563002: [iOS Clean] Added dialogs UI support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.h

Issue 2929563002: [iOS Clean] Added dialogs UI support.

Patch Set: Added DialogMediator Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/dialogs/dialog_text_field_item.mm ('K') | « ios/clean/chrome/browser/ui/dialogs/dialog_text_field_item.mm ('k') | ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.mm » ('j') | ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_DIALOG_VIEW_CONTROLLER_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_DIALOG_VIEW_CONTROLLER_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 #import "ios/clean/chrome/browser/ui/dialogs/dialog_consumer.h"

	11

	12 @protocol DialogDismissalCommands;

	13

	14 // Class used to display dialogs.
	marq (ping after 24h) 2017/06/14 10:52:15 Is this expected to be subclassed? Is this expected to be subclassed? kkhorimoto 2017/06/23 06:24:18 No, I'll add a comment for that. It should be mor Show quoted text On 2017/06/14 10:52:15, marq (ping after 24h) wrote: > Is this expected to be subclassed? No, I'll add a comment for that. It should be more clear that only the coordinator should be subclassed (now that there's a DialogCoordinator).
	15 @interface DialogViewController : UIAlertController<DialogConsumer>

	16

	17 // Initializer for a dialog with \|style\| that uses \|dispatcher\| to manager its
	marq (ping after 24h) 2017/06/14 10:52:16 mananger -> manage mananger -> manage kkhorimoto 2017/06/23 06:24:18 Done. Show quoted text On 2017/06/14 10:52:16, marq (ping after 24h) wrote: > mananger -> manage Done.
	18 // dismissal.

	19 - (instancetype)initWithStyle:(UIAlertControllerStyle)style
	marq (ping after 24h) 2017/06/14 10:52:15 Style should always be UIAlertControllerStyleAlert Style should always be UIAlertControllerStyleAlert, right? kkhorimoto 2017/06/23 06:24:18 Nope, the dialog blocking confirmation is an actio Show quoted text On 2017/06/14 10:52:15, marq (ping after 24h) wrote: > Style should always be UIAlertControllerStyleAlert, right? Nope, the dialog blocking confirmation is an action sheet on iPhones.
	20 dispatcher:(id<DialogDismissalCommands>)dispatcher;

	21

	22 @end

	23

	24 #endif // IOS_CLEAN_CHROME_BROWSER_UI_DIALOGS_DIALOG_VIEW_CONTROLLER_H_

OLD	NEW