ios/clean/chrome/browser/ui/commands/dialog_commands.h - Issue 2929563002: [iOS Clean] Added dialogs UI support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/dialog_commands.h

Issue 2929563002: [iOS Clean] Added dialogs UI support.

Patch Set: Added DialogMediator Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/commands/BUILD.gn ('k') | ios/clean/chrome/browser/ui/dialogs/BUILD.gn » ('j') | ios/clean/chrome/browser/ui/dialogs/dialog_button_item.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_DIALOG_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_DIALOG_COMMANDS_H_

	7

	8 // Command protocol for dismissing DialogConsumers.

	9 @protocol DialogDismissalCommands
	marq (ping after 24h) 2017/06/14 10:52:14 Maybe just -DialogCommands, so if (as seems likely Maybe just -DialogCommands, so if (as seems likely) we have a -showDialog ... command, it has a logical home. kkhorimoto 2017/06/23 06:24:17 I don't think there will be a \|-showDialog\| comman Show quoted text On 2017/06/14 10:52:14, marq (ping after 24h) wrote: > Maybe just -DialogCommands, so if (as seems likely) we have a -showDialog ... > command, it has a logical home. I don't think there will be a \|-showDialog\| command, as the DialogCoordinator is intended to be subclassed. There might be commands in the future to show specific types of dialogs, but they should be specific to the subclass rather than the generalized dialogs support implemented by DialogConsumers.
	10

	11 // Called to dismiss the dialog. \|buttonTag\| is the tag of the DialogButtonItem
	marq (ping after 24h) 2017/06/14 10:52:14 Commands shouldn't presume a particular UI impleme Commands shouldn't presume a particular UI implementation. I'm fine if there's an opaque 'dialog identifier' that's used, but how it's generated, and what it corresponds to in the UI (if anything) isn't part of the command definition. Also, 'tag' should be reserved for its use in the UIView sense (an integer identifier), so calling something a 'tag' that's an object type (id) is confusing. kkhorimoto 2017/06/23 06:24:17 I changed tag to identifier and updated the commen Show quoted text On 2017/06/14 10:52:14, marq (ping after 24h) wrote: > Commands shouldn't presume a particular UI implementation. I'm fine if there's > an opaque 'dialog identifier' that's used, but how it's generated, and what it > corresponds to in the UI (if anything) isn't part of the command definition. > > Also, 'tag' should be reserved for its use in the UIView sense (an integer > identifier), so calling something a 'tag' that's an object type (id) is > confusing. I changed tag to identifier and updated the comments to make them a little less tightly coupled with UI assumptions.
	12 // corresponding to the button that dismissed the dialog, or nil if dismissed

	13 // programmatically. \|inputStrings\| are the text field values, and are returned

	14 // in the same order as the text field items were provided to the consumer.

	15 - (void)dismissDialogWithButtonTag:(id)buttonTag

	16 userInputStrings:(NSArray<NSString>)inputStrings;

	17

	18 @end

	19

	20 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_DIALOG_COMMANDS_H_

OLD	NEW