Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.cc

Issue 2929533002: Fill has_password_field for password reuse ping (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.cc
diff --git a/components/safe_browsing/password_protection/password_protection_request.cc b/components/safe_browsing/password_protection/password_protection_request.cc
index 0f74a1eebb88878ad158cdf0eb0d0ca9049bd7da..8031d6e23047599a1665ff9d570e2c00e0b625f0 100644
--- a/components/safe_browsing/password_protection/password_protection_request.cc
+++ b/components/safe_browsing/password_protection/password_protection_request.cc
@@ -26,6 +26,7 @@ PasswordProtectionRequest::PasswordProtectionRequest(
const GURL& password_form_frame_url,
const std::string& saved_domain,
LoginReputationClientRequest::TriggerType type,
+ bool has_password_field,
PasswordProtectionService* pps,
int request_timeout_in_ms)
: web_contents_(web_contents),
@@ -34,6 +35,7 @@ PasswordProtectionRequest::PasswordProtectionRequest(
password_form_frame_url_(password_form_frame_url),
saved_domain_(saved_domain),
request_type_(type),
+ has_password_field(has_password_field),
password_protection_service_(pps),
request_timeout_in_ms_(request_timeout_in_ms),
weakptr_factory_(this) {
@@ -124,6 +126,7 @@ void PasswordProtectionRequest::FillRequestProto() {
break;
}
case LoginReputationClientRequest::PASSWORD_REUSE_EVENT: {
+ main_frame->set_has_password_field(has_password_field);
// TODO(jialiul): Fill more password reuse related information when ready.
break;
}

Powered by Google App Engine
This is Rietveld 408576698