Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 292953003: Update V8 to version 3.27.8 (based on bleeding_edge revision r21370). (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update V8 to version 3.27.8 (based on bleeding_edge revision r21370). Please reply to the V8 sheriff jkummerow@chromium.org in case of problems. TBR=jkummerow@chromium.org NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Michael Achenbach
6 years, 7 months ago (2014-05-20 07:11:22 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-20 07:16:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/292953003/1
6 years, 7 months ago (2014-05-20 07:16:10 UTC) #3
Michael Achenbach
The CQ bit was unchecked by machenbach@chromium.org
6 years, 7 months ago (2014-05-20 13:22:27 UTC) #4
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 7 months ago (2014-05-20 13:22:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/292953003/1
6 years, 7 months ago (2014-05-20 13:23:34 UTC) #6
commit-bot: I haz the power
Change committed as 271630
6 years, 7 months ago (2014-05-20 13:25:14 UTC) #7
Alexei Svitkine (slow)
Please don't land changes when the tree is closed. Tree being closed means there's active ...
6 years, 7 months ago (2014-05-20 14:20:04 UTC) #8
Ilya Sherman
Why was this landed with NOTREECHECKS=true? That does not seem appropriate for rolling v8. It ...
6 years, 7 months ago (2014-05-20 14:20:23 UTC) #9
Michael Achenbach
On 2014/05/20 14:20:23, Ilya Sherman wrote: > Why was this landed with NOTREECHECKS=true? That does ...
6 years, 7 months ago (2014-05-20 14:27:20 UTC) #10
Ilya Sherman
6 years, 7 months ago (2014-05-20 14:30:03 UTC) #11
Message was sent while issue was closed.
On 2014/05/20 14:27:20, Michael Achenbach wrote:
> On 2014/05/20 14:20:23, Ilya Sherman wrote:
> > Why was this landed with NOTREECHECKS=true?  That does not seem appropriate
> for
> > rolling v8.  It makes it harder to diagnose tree closures.
> 
> Sorry for that. If our rolls don't make it into the canary we get hard
> diagnostics problems on our side. And the tree was quite stale... + all tries
> succeeded.

The best thing to do in this case is to help triage the tree failures.  That
way, problems can be diagnosed and fixed early, rather than when the history
grows muddy with unrelated commits.  (And, yes, it would be great if we had
24-hour sheriff coverage.  I think there was a thread on chromium-dev about this
recently, but I don't recall the outcome.)

Powered by Google App Engine
This is Rietveld 408576698