Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 292953002: Remove mangling for custom methods in dart:_blink (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix name mangling in native_DOMImplementation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | tools/dom/src/blink_native_DOMImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemnative.py
diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py
index 3c52226ed953ed001977d1c96adcb82a71ccb431..f0a3ed011be8132e6dc5d5cad062b1dc999db393 100644
--- a/tools/dom/scripts/systemnative.py
+++ b/tools/dom/scripts/systemnative.py
@@ -345,14 +345,18 @@ def DeriveNativeName(interface_name, name, suffix):
fields.append(suffix)
return "_".join(fields)
-def DeriveResolverString(interface_id, operation_id, native_suffix, type_ids):
+def DeriveResolverString(interface_id, operation_id, native_suffix, type_ids, is_custom=False):
type_string = \
"_".join(map(TypeIdToBlinkName, type_ids))
if native_suffix:
operation_id = "%s_%s" % (operation_id, native_suffix)
- components = \
- [TypeIdToBlinkName(interface_id), operation_id,
- "RESOLVER_STRING", str(len(type_ids)), type_string]
+ if is_custom:
+ components = \
+ [TypeIdToBlinkName(interface_id), operation_id]
+ else:
+ components = \
+ [TypeIdToBlinkName(interface_id), operation_id,
+ "RESOLVER_STRING", str(len(type_ids)), type_string]
return "_".join(components)
# FIXME(leafp) This should really go elsewhere. I think the right thing
@@ -1168,10 +1172,10 @@ class DartiumBackend(HtmlDartGenerator):
auto_scope_setup = self._GenerateAutoSetupScope(info.name, native_suffix)
if self._dart_use_blink:
type_ids = [argument.type.id
- for argument in operation.arguments[:argument_count]]
+ for argument in operation.arguments[:len(info.param_infos)]]
resolver_string = \
DeriveResolverString(self._interface.id, operation.id,
- native_suffix, type_ids)
+ native_suffix, type_ids, is_custom)
else:
resolver_string = None
cpp_callback_name = self._GenerateNativeBinding(
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | tools/dom/src/blink_native_DOMImplementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698