Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/perf/page_sets/chrome_signin.py

Issue 2929513002: Explicitly set story names for startup benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/blank_page_with_large_profile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/chrome_signin.py
diff --git a/tools/perf/page_sets/chrome_signin.py b/tools/perf/page_sets/chrome_signin.py
index b7eabb2eadc79200be90d52c81192a71359a5294..db695ff4bcdbb451e4e5755dbfd54ed44c9f271b 100644
--- a/tools/perf/page_sets/chrome_signin.py
+++ b/tools/perf/page_sets/chrome_signin.py
@@ -12,12 +12,14 @@ class ChromeSigninPage(page_module.Page):
"""A page that signs in a user to Chrome."""
def __init__(self, page_set):
+ url = 'chrome://signin-internals'
super(ChromeSigninPage, self).__init__(
- url='chrome://signin-internals',
+ url=url,
page_set=page_set,
credentials_path='data/chrome_signin_credentials.json',
credentials_bucket=story.INTERNAL_BUCKET,
- shared_page_state_class=shared_page_state.SharedDesktopPageState)
+ shared_page_state_class=shared_page_state.SharedDesktopPageState,
+ name=url)
def RunPageInteractions(self, action_runner):
# Use page.credentials_path because it is automatically translated into a
@@ -31,5 +33,6 @@ class ChromeSigninPageSet(story.StorySet):
def __init__(self):
super(ChromeSigninPageSet, self).__init__(
archive_data_file='data/chrome_signin_archive.json',
- cloud_storage_bucket=story.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET,
+ verify_names=True)
self.AddStory(ChromeSigninPage(self))
« no previous file with comments | « tools/perf/page_sets/blank_page_with_large_profile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698