Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: tools/perf/page_sets/blank_page.py

Issue 2929513002: Explicitly set story names for startup benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/blank_page_with_large_profile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/blank_page.py
diff --git a/tools/perf/page_sets/blank_page.py b/tools/perf/page_sets/blank_page.py
index 1858cfa2f31538951f6cd576d99b6e8582e28263..7ffff30a62ca52fd07562b46205c06d526b96038 100644
--- a/tools/perf/page_sets/blank_page.py
+++ b/tools/perf/page_sets/blank_page.py
@@ -7,8 +7,8 @@ from page_sets.startup_pages import BrowserStartupSharedState
class BlankPage(page_module.Page):
- def __init__(self, url, page_set):
- super(BlankPage, self).__init__(url, page_set=page_set)
+ def __init__(self, url, page_set, name):
+ super(BlankPage, self).__init__(url, page_set=page_set, name=name)
def RunPageInteractions(self, action_runner):
# Request a RAF and wait for it to be processed to ensure that the metric
@@ -27,8 +27,9 @@ class BlankPageSet(story.StorySet):
"""A single blank page."""
def __init__(self):
- super(BlankPageSet, self).__init__()
- self.AddStory(BlankPage('file://blank_page/blank_page.html', self))
+ super(BlankPageSet, self).__init__(verify_names=True)
+ self.AddStory(BlankPage('file://blank_page/blank_page.html',
+ self, 'blank_page.html'))
class BlankPageTBM(page_module.Page):
« no previous file with comments | « no previous file | tools/perf/page_sets/blank_page_with_large_profile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698