Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2929503002: refactor _emitFunctionBody slightly to simplify it (Closed)

Created:
3 years, 6 months ago by Jennifer Messerly
Modified:
3 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

refactor _emitFunctionBody slightly to simplify it R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/332b34aba8b0312da1529f6be9d32a08aff04f3b

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -49 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 7 chunks +39 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
just a small change. I need to add covariance checks for (some) generic method type ...
3 years, 6 months ago (2017-06-06 21:06:32 UTC) #1
Jennifer Messerly
3 years, 6 months ago (2017-06-06 21:06:38 UTC) #3
vsm
lgtm
3 years, 6 months ago (2017-06-06 22:44:37 UTC) #4
Jennifer Messerly
3 years, 6 months ago (2017-06-06 22:59:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
332b34aba8b0312da1529f6be9d32a08aff04f3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698