Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)
Patch Set: Rebasing... Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
index d73de59408045cbad62d330302496e7b8e58e166..fb94cbe84251313096d5bb1a512eccf5613edc2e 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
@@ -2822,8 +2822,11 @@ void LocalFrameView::UpdateDocumentAnnotatedRegions() const {
if (new_regions == document->AnnotatedRegions())
return;
document->SetAnnotatedRegions(new_regions);
- if (Page* page = frame_->GetPage())
- page->GetChromeClient().AnnotatedRegionsChanged();
+
+ // Client should always be present, because this method cannot be called
+ // during detach (LocalFrame::Detach calls SetView(nullptr)).
dcheng 2017/06/08 20:02:56 I would omit this comment: the precise details of
Łukasz Anforowicz 2017/06/08 20:51:37 Done.
+ DCHECK(frame_->Client());
+ frame_->Client()->AnnotatedRegionsChanged();
}
void LocalFrameView::DidAttachDocument() {
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrameClient.h ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698