Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)
Patch Set: Removing the CHECK used to find test coverage [found in LaunchWebAuthFlowFunctionTest]. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
index ab4eeb4512b421d2b4390744847448881398114f..90488c05a93a1d5c725984cad0ad80ed05eb3d63 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
@@ -2823,8 +2823,8 @@ void LocalFrameView::UpdateDocumentAnnotatedRegions() const {
if (new_regions == document->AnnotatedRegions())
return;
document->SetAnnotatedRegions(new_regions);
- if (Page* page = frame_->GetPage())
- page->GetChromeClient().AnnotatedRegionsChanged();
+ if (frame_->Client())
dcheng 2017/06/07 20:22:35 I strongly suspect that this should be a DCHECK--t
Łukasz Anforowicz 2017/06/08 16:29:24 Done (I've also added a comment - please shout if
+ frame_->Client()->AnnotatedRegionsChanged();
}
void LocalFrameView::DidAttachDocument() {

Powered by Google App Engine
This is Rietveld 408576698