third_party/WebKit/Source/core/frame/LocalFrameView.cpp - Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)

Patch Set: Addressed CR feedback from rdevlin.cronin@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp

index d73de59408045cbad62d330302496e7b8e58e166..2be1b263f5ce8de4ade05e49e9317c93e77a9db9 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrameView.cpp

@@ -2822,8 +2822,9 @@ void LocalFrameView::UpdateDocumentAnnotatedRegions() const {

if (new_regions == document->AnnotatedRegions())

return;

document->SetAnnotatedRegions(new_regions);

- if (Page* page = frame_->GetPage())

- page->GetChromeClient().AnnotatedRegionsChanged();

+ DCHECK(frame_->Client());

+ frame_->Client()->AnnotatedRegionsChanged();

}

void LocalFrameView::DidAttachDocument() {