Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)
Patch Set: Removing the CHECK used to find test coverage [found in LaunchWebAuthFlowFunctionTest]. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 return kWebPageVisibilityStateVisible; 788 return kWebPageVisibilityStateVisible;
789 } 789 }
790 790
791 // Overwrites the given URL to use an HTML5 embed if possible. 791 // Overwrites the given URL to use an HTML5 embed if possible.
792 // An empty URL is returned if the URL is not overriden. 792 // An empty URL is returned if the URL is not overriden.
793 virtual WebURL OverrideFlashEmbedWithHTML(const WebURL& url) { 793 virtual WebURL OverrideFlashEmbedWithHTML(const WebURL& url) {
794 return WebURL(); 794 return WebURL();
795 } 795 }
796 796
797 // Loading -------------------------------------------------------------- 797 // Loading --------------------------------------------------------------
798
798 virtual std::unique_ptr<blink::WebURLLoader> CreateURLLoader() { 799 virtual std::unique_ptr<blink::WebURLLoader> CreateURLLoader() {
799 NOTREACHED(); 800 NOTREACHED();
800 return nullptr; 801 return nullptr;
801 } 802 }
803
804 // Other methods --------------------------------------------------------
dcheng 2017/06/07 20:22:35 Nit: let's just call this Draggable regions still,
Łukasz Anforowicz 2017/06/08 16:29:24 Done: - I've moved the declaration into "Geometry
805
806 // Informs the browser that the draggable regions have been updated.
807 virtual void DraggableRegionsChanged() {}
802 }; 808 };
803 809
804 } // namespace blink 810 } // namespace blink
805 811
806 #endif 812 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698