Move handling of DraggableRegionsChanged notification from "view" to "frame".

extensions/browser/app_window/app_window_contents.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window_contents.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 79 matching lines @@
 }
 
 content::WebContents* AppWindowContentsImpl::GetWebContents() const {
   return web_contents_.get();
 }
 
 WindowController* AppWindowContentsImpl::GetWindowController() const {
   return nullptr;
 }
 
-bool AppWindowContentsImpl::OnMessageReceived(const IPC::Message& message) {
+bool AppWindowContentsImpl::OnMessageReceived(
+    const IPC::Message& message,
+    content::RenderFrameHost* sender) {
   bool handled = true;
-  IPC_BEGIN_MESSAGE_MAP(AppWindowContentsImpl, message)
+  IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(AppWindowContentsImpl, message, sender)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_UpdateDraggableRegions,
                         UpdateDraggableRegions)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AppWindowContentsImpl::ReadyToCommitNavigation(
     content::NavigationHandle* handle) {
   if (!is_window_ready_)
     host_->OnReadyToCommitFirstNavigation();
 }
 
 void AppWindowContentsImpl::UpdateDraggableRegions(
+    content::RenderFrameHost* sender,
     const std::vector<DraggableRegion>& regions) {

[Łukasz Anforowicz, 2017/06/07 18:25:03]

Test coverage of this CL is not that great:

- There is *some* test coverage - some tests crash if I insert a CHECK(false)
here (e.g. LaunchWebAuthFlowFunctionTest).

- OTOH, the test coverage is superficial - no tests fail if I just return early
here.


I hope it is okay to depend on the limited test coverage described above and
then monitor crash rates (which should hopefully go down after this CL for
https://crbug.com/645472 - blink::WebDocument::draggableRegions).

I guess that in theory we could say that we'll add test coverage in a follow-up
CL, but I'd rather not sign up for that and so the promise of the follow-up test
coverage would be rather hollow... :-/

   host_->UpdateDraggableRegions(regions);
 }
 
 void AppWindowContentsImpl::SuspendRenderFrameHost(
     content::RenderFrameHost* rfh) {
   DCHECK(rfh);
   // Don't bother blocking requests if the renderer side is already good to go.
   if (is_window_ready_)
     return;
   is_blocking_requests_ = true;
   rfh->BlockRequestsForFrame();
 }
 
 }  // namespace extensions