Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)
Patch Set: Addressed CR feedback from rdevlin.cronin@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
962 } 962 }
963 963
964 void ChromeClientImpl::RequestPointerUnlock(LocalFrame* frame) { 964 void ChromeClientImpl::RequestPointerUnlock(LocalFrame* frame) {
965 LocalFrame& local_root = frame->LocalFrameRoot(); 965 LocalFrame& local_root = frame->LocalFrameRoot();
966 return WebLocalFrameImpl::FromFrame(&local_root) 966 return WebLocalFrameImpl::FromFrame(&local_root)
967 ->FrameWidget() 967 ->FrameWidget()
968 ->Client() 968 ->Client()
969 ->RequestPointerUnlock(); 969 ->RequestPointerUnlock();
970 } 970 }
971 971
972 void ChromeClientImpl::AnnotatedRegionsChanged() {
973 if (WebViewClient* client = web_view_->Client())
974 client->DraggableRegionsChanged();
975 }
976
977 void ChromeClientImpl::DidAssociateFormControlsAfterLoad(LocalFrame* frame) { 972 void ChromeClientImpl::DidAssociateFormControlsAfterLoad(LocalFrame* frame) {
978 WebLocalFrameImpl* webframe = WebLocalFrameImpl::FromFrame(frame); 973 WebLocalFrameImpl* webframe = WebLocalFrameImpl::FromFrame(frame);
979 if (webframe->AutofillClient()) 974 if (webframe->AutofillClient())
980 webframe->AutofillClient()->DidAssociateFormControlsDynamically(); 975 webframe->AutofillClient()->DidAssociateFormControlsDynamically();
981 } 976 }
982 977
983 void ChromeClientImpl::ShowVirtualKeyboardOnElementFocus(LocalFrame& frame) { 978 void ChromeClientImpl::ShowVirtualKeyboardOnElementFocus(LocalFrame& frame) {
984 WebLocalFrameImpl::FromFrame(frame.LocalFrameRoot()) 979 WebLocalFrameImpl::FromFrame(frame.LocalFrameRoot())
985 ->FrameWidget() 980 ->FrameWidget()
986 ->Client() 981 ->Client()
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1141 if (RuntimeEnabledFeatures::PresentationEnabled()) 1136 if (RuntimeEnabledFeatures::PresentationEnabled())
1142 PresentationController::ProvideTo(frame, client->PresentationClient()); 1137 PresentationController::ProvideTo(frame, client->PresentationClient());
1143 if (RuntimeEnabledFeatures::AudioOutputDevicesEnabled()) { 1138 if (RuntimeEnabledFeatures::AudioOutputDevicesEnabled()) {
1144 ProvideAudioOutputDeviceClientTo(frame, 1139 ProvideAudioOutputDeviceClientTo(frame,
1145 new AudioOutputDeviceClientImpl(frame)); 1140 new AudioOutputDeviceClientImpl(frame));
1146 } 1141 }
1147 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher()); 1142 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
1148 } 1143 }
1149 1144
1150 } // namespace blink 1145 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698