Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: content/public/renderer/render_view_observer.h

Issue 2929493003: Move handling of DraggableRegionsChanged notification from "view" to "frame". (Closed)
Patch Set: Addressed CR feedback from rdevlin.cronin@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 6 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
11 #include "ipc/ipc_listener.h" 11 #include "ipc/ipc_listener.h"
12 #include "ipc/ipc_sender.h" 12 #include "ipc/ipc_sender.h"
13 13
14 class GURL; 14 class GURL;
15 15
16 namespace blink { 16 namespace blink {
17 class WebFrame;
18 class WebGestureEvent; 17 class WebGestureEvent;
19 class WebLocalFrame; 18 class WebLocalFrame;
20 struct WebURLError; 19 struct WebURLError;
21 } 20 }
22 21
23 namespace content { 22 namespace content {
24 23
25 class RenderView; 24 class RenderView;
26 class RenderViewImpl; 25 class RenderViewImpl;
27 26
28 // Base class for objects that want to filter incoming IPCs, and also get 27 // Base class for objects that want to filter incoming IPCs, and also get
29 // notified of changes to the frame. 28 // notified of changes to the frame.
30 class CONTENT_EXPORT RenderViewObserver : public IPC::Listener, 29 class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
31 public IPC::Sender { 30 public IPC::Sender {
32 public: 31 public:
33 // A subclass can use this to delete itself. If it does not, the subclass must 32 // A subclass can use this to delete itself. If it does not, the subclass must
34 // always null-check each call to render_view() becase the RenderView can 33 // always null-check each call to render_view() becase the RenderView can
35 // go away at any time. 34 // go away at any time.
36 virtual void OnDestruct() = 0; 35 virtual void OnDestruct() = 0;
37 36
38 // These match the WebKit API notifications 37 // These match the WebKit API notifications
39 virtual void DidStartLoading() {} 38 virtual void DidStartLoading() {}
40 virtual void DidStopLoading() {} 39 virtual void DidStopLoading() {}
41 virtual void DidFailProvisionalLoad(blink::WebLocalFrame* frame, 40 virtual void DidFailProvisionalLoad(blink::WebLocalFrame* frame,
42 const blink::WebURLError& error) {} 41 const blink::WebURLError& error) {}
43 virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame, 42 virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,
44 bool is_new_navigation) {} 43 bool is_new_navigation) {}
45 virtual void DidClearWindowObject(blink::WebLocalFrame* frame) {} 44 virtual void DidClearWindowObject(blink::WebLocalFrame* frame) {}
46 virtual void DraggableRegionsChanged(blink::WebFrame* frame) {}
47 virtual void DidCommitCompositorFrame() {} 45 virtual void DidCommitCompositorFrame() {}
48 virtual void DidUpdateLayout() {} 46 virtual void DidUpdateLayout() {}
49 47
50 // These match the RenderView methods. 48 // These match the RenderView methods.
51 virtual void DidHandleGestureEvent(const blink::WebGestureEvent& event) {} 49 virtual void DidHandleGestureEvent(const blink::WebGestureEvent& event) {}
52 50
53 // These match incoming IPCs. 51 // These match incoming IPCs.
54 virtual void Navigate(const GURL& url) {} 52 virtual void Navigate(const GURL& url) {}
55 53
56 virtual void OnZoomLevelChanged() {} 54 virtual void OnZoomLevelChanged() {}
(...skipping 27 matching lines...) Expand all
84 RenderViewImpl* render_view_; 82 RenderViewImpl* render_view_;
85 // The routing ID of the associated RenderView. 83 // The routing ID of the associated RenderView.
86 int routing_id_; 84 int routing_id_;
87 85
88 DISALLOW_COPY_AND_ASSIGN(RenderViewObserver); 86 DISALLOW_COPY_AND_ASSIGN(RenderViewObserver);
89 }; 87 };
90 88
91 } // namespace content 89 } // namespace content
92 90
93 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_ 91 #endif // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_OBSERVER_H_
OLDNEW
« no previous file with comments | « content/public/renderer/render_frame_observer.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698