Move handling of DraggableRegionsChanged notification from "view" to "frame".

extensions/renderer/extension_frame_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/extension_frame_helper.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 #include "base/timer/elapsed_timer.h"
 #include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_view.h"
 #include "extensions/common/api/messaging/message.h"
 #include "extensions/common/api/messaging/port_id.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/renderer/console.h"
 #include "extensions/renderer/content_watcher.h"
 #include "extensions/renderer/dispatcher.h"
 #include "extensions/renderer/messaging_bindings.h"
 #include "extensions/renderer/script_context.h"
@@ skipping 307 matching lines @@
     const std::string& function_name,
     const base::ListValue& args) {
   extension_dispatcher_->InvokeModuleSystemMethod(
       render_frame(), extension_id, module_name, function_name, args);
 }
 
 void ExtensionFrameHelper::OnDestruct() {
   delete this;
 }
 
+void ExtensionFrameHelper::DraggableRegionsChanged() {
+  blink::WebVector<blink::WebDraggableRegion> webregions =
+      render_frame()->GetWebFrame()->GetDocument().DraggableRegions();
+  std::vector<DraggableRegion> regions;
+  for (size_t i = 0; i < webregions.size(); ++i) {
+    DraggableRegion region;
+    render_frame()->GetRenderView()->ConvertViewportToWindowViaWidget(

[alexmos, 2017/06/08 21:19:00]

Is this going to work for a swapped-out RenderView?  I would think this should
instead use something like
render_frame()->GetRenderWidget()->ConvertViewportToWindow(), though we don't
publicly expose RenderWidget. :(  I don't know if there's a behavioral
difference in practice for the conversion (e.g., I don't remember if we set
things like GetOriginalDeviceScaleFactor for swapped-out RVs or not).  James or
Ken would probably know.

[Łukasz Anforowicz, 2017/06/08 22:27:13]

Thanks for catching this.

I guess one option would be to bail out early if the main frame is not a local
frame.  (before this CL, such situation would result in a crash).

Ken: Could you please comment on what to do here?

[kenrb, 2017/06/09 15:43:25]

As far as I know, using ConvertViewportToWindowViaWidget() usage should be okay.
Swapped-out RenderViews should still get Resize messages with correct
ResizeParams. In Blink the information gets a bit sparser because WebViewImpl's
resize code bails early when mainFrame() is remote, but in content/ the
information is there.

A second question I see is whether, in an OOPIF process, the
Document::DraggableRegions() actually returns regions in Viewport coordinates,
which this code assumes when it converts from Viewport to Window coords. I just
took a quick look at the code, and I think the answer is (mostly) yes, which was
a happy surprise. I think that works because of the IntersectionObserver changes
I landed earlier this year, which taught Blink layout code to successfully map
coords to the root viewport. I say 'mostly yes' because there might be skew if
there are transforms applied to the OOPIF by the embedding frame. We don't
currently take that into account.

+        &webregions[i].bounds);
+    region.bounds = webregions[i].bounds;
+    region.draggable = webregions[i].draggable;
+    regions.push_back(region);
+  }
+  Send(new ExtensionHostMsg_UpdateDraggableRegions(routing_id(), regions));
+}
+
 }  // namespace extensions