Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/browser/android/vr_shell/gl_browser_interface.h

Issue 2929483003: VR: Further split common code from Android-specific code. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/BUILD.gn ('k') | chrome/browser/android/vr_shell/ui_browser_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/gl_browser_interface.h
diff --git a/chrome/browser/android/vr_shell/vr_browser_interface.h b/chrome/browser/android/vr_shell/gl_browser_interface.h
similarity index 61%
rename from chrome/browser/android/vr_shell/vr_browser_interface.h
rename to chrome/browser/android/vr_shell/gl_browser_interface.h
index eeb4f1bb36b88a945092ed59046050a72f3f61dc..ae7952912d83043eddc6c0d09b1e8f53781dde0f 100644
--- a/chrome/browser/android/vr_shell/vr_browser_interface.h
+++ b/chrome/browser/android/vr_shell/gl_browser_interface.h
@@ -2,17 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_ANDROID_VR_SHELL_VR_BROWSER_INTERFACE_H_
-#define CHROME_BROWSER_ANDROID_VR_SHELL_VR_BROWSER_INTERFACE_H_
+#ifndef CHROME_BROWSER_ANDROID_VR_SHELL_GL_BROWSER_INTERFACE_H_
+#define CHROME_BROWSER_ANDROID_VR_SHELL_GL_BROWSER_INTERFACE_H_
#include <memory>
#include "base/android/jni_weak_ref.h"
-#include "base/bind.h"
-#include "base/memory/weak_ptr.h"
-#include "base/time/time.h"
#include "chrome/browser/android/vr_shell/ui_interface.h"
-#include "chrome/browser/android/vr_shell/ui_unsupported_mode.h"
#include "device/vr/android/gvr/gvr_gamepad_data_provider.h"
#include "device/vr/vr_service.mojom.h"
@@ -22,11 +18,11 @@ class WebInputEvent;
namespace vr_shell {
-// An interface for communication with Vr Browser. Many of the functions in this
-// interface are proxies to methods on VrShell.
-class VrBrowserInterface {
+// An interface for the GL thread to communicate with VrShell. Many of the
+// functions in this interface are proxies to methods on VrShell.
+class GlBrowserInterface {
public:
- virtual ~VrBrowserInterface() = default;
+ virtual ~GlBrowserInterface() = default;
virtual void ContentSurfaceChanged(jobject surface) = 0;
virtual void GvrDelegateReady() = 0;
@@ -36,18 +32,13 @@ class VrBrowserInterface {
virtual void ProcessContentGesture(
std::unique_ptr<blink::WebInputEvent> event) = 0;
virtual void ForceExitVr() = 0;
- virtual void ExitPresent() = 0;
- virtual void ExitFullscreen() = 0;
virtual void RunVRDisplayInfoCallback(
const base::Callback<void(device::mojom::VRDisplayInfoPtr)>& callback,
device::mojom::VRDisplayInfoPtr* info) = 0;
virtual void OnContentPaused(bool enabled) = 0;
- virtual void NavigateBack() = 0;
- virtual void ExitCct() = 0;
virtual void ToggleCardboardGamepad(bool enabled) = 0;
- virtual void OnUnsupportedMode(UiUnsupportedMode mode) = 0;
};
} // namespace vr_shell
-#endif // CHROME_BROWSER_ANDROID_VR_SHELL_VR_BROWSER_INTERFACE_H_
+#endif // CHROME_BROWSER_ANDROID_VR_SHELL_GL_BROWSER_INTERFACE_H_
« no previous file with comments | « chrome/browser/android/vr_shell/BUILD.gn ('k') | chrome/browser/android/vr_shell/ui_browser_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698