Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 292943002: fix the visual diff of raster vs gpu -- vertices_80 (Closed)

Created:
6 years, 7 months ago by yunchao
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix the visual diff of raster vs gpu -- vertices_80. The sw-raster is correct, all images are blurry. While some images generated by gpu doesn't respect SkPaint's alpha value. In gpu path, when pass SkPaint's alpha and color to GrPaint by SkPaint2GrPaintNoShader, either alpha or colors can't not be passed. We can't pass both of them by the API. Premultiply paint's alpha to colors's alpha in drawVertices, and pass colors to GrPaint. The rendering result will respect colors in drawVertices, and the alpha value set in SkPaint as well. BUG=skia:2592 Committed: http://code.google.com/p/skia/source/detail?r=14863

Patch Set 1 #

Patch Set 2 : update ignored-tests.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yunchao
PTAL. Thanks!
6 years, 7 months ago (2014-05-22 07:03:16 UTC) #1
bsalomon
lgtm, any tests that need to be added to ignored-tests.txt for rebaselining?
6 years, 7 months ago (2014-05-22 13:11:36 UTC) #2
yunchao
On 2014/05/22 13:11:36, bsalomon wrote: > lgtm, any tests that need to be added to ...
6 years, 7 months ago (2014-05-22 13:38:06 UTC) #3
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 7 months ago (2014-05-23 08:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/292943002/20001
6 years, 7 months ago (2014-05-23 08:03:42 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 08:09:33 UTC) #6
Message was sent while issue was closed.
Change committed as 14863

Powered by Google App Engine
This is Rietveld 408576698