Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2929413003: Use service_account_token for task retry (Closed)

Created:
3 years, 6 months ago by kjlubick
Modified:
3 years, 6 months ago
Reviewers:
KevinL, rmistry, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M appengine/swarming/ui/build/js/js.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
kjlubick
3 years, 6 months ago (2017-06-12 13:06:36 UTC) #3
kjlubick
On 2017/06/12 at 13:06:36, kjlubick wrote: > This has been tested in chrome-swarming
3 years, 6 months ago (2017-06-12 13:06:48 UTC) #4
rmistry
lgtm
3 years, 6 months ago (2017-06-12 13:10:25 UTC) #5
KevinL
lgtm
3 years, 6 months ago (2017-06-12 13:13:15 UTC) #7
M-A Ruel
lgtm
3 years, 6 months ago (2017-06-12 13:17:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929413003/10001
3 years, 6 months ago (2017-06-12 13:17:49 UTC) #12
kjlubick
3 years, 6 months ago (2017-06-12 13:23:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
354c78bdb1c9202ce25f0c25bb2d768cf623bcdb.

Powered by Google App Engine
This is Rietveld 408576698