Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2929383002: Various semantic checks on field initializers. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -15 lines) Patch
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 2 chunks +40 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 5 chunks +14 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 5 chunks +24 lines, -3 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 3 chunks +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-11 11:29:59 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-12 02:21:48 UTC) #3
ahe
3 years, 6 months ago (2017-06-12 09:15:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
080a25f3a6d46013921d587a51248fa6ca0030bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698