Issue 2929363002: Implement GC for FileState(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2929363002: Implement GC for FileState(s). (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, erikcorry

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -1 line)			Patch
M	pkg/front_end/lib/src/incremental/file_state.dart	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	pkg/front_end/test/src/incremental/file_state_test.dart	View	1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

ahe

lgtm Adding Erik in case he has any ideas for ways to take advantage of ...

3 years, 6 months ago (2017-06-11 09:46:22 UTC) #2

scheglov

3 years, 6 months ago (2017-06-12 15:47:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e8ceb60ab3dddc68422c7049295f55c4f63df29 (presubmit successful).