Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: runtime/vm/virtual_memory_test.cc

Issue 2929203002: [Fuchsia] Give VMOs names (Closed)
Patch Set: Fix tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | runtime/vm/virtual_memory_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/virtual_memory_test.cc
diff --git a/runtime/vm/virtual_memory_test.cc b/runtime/vm/virtual_memory_test.cc
index c652f8c2b61ad7c32aab287b00b9176c8b4a014d..a4c68d2f61a96249db5d7610956ab12f5d93528d 100644
--- a/runtime/vm/virtual_memory_test.cc
+++ b/runtime/vm/virtual_memory_test.cc
@@ -36,7 +36,7 @@ VM_UNIT_TEST_CASE(AllocateVirtualMemory) {
EXPECT(!vm->Contains(0));
EXPECT(!vm->Contains(static_cast<uword>(-1)));
- vm->Commit(false);
+ vm->Commit(false, NULL);
char* buf = reinterpret_cast<char*>(vm->address());
EXPECT(IsZero(buf, buf + vm->size()));
@@ -58,31 +58,31 @@ VM_UNIT_TEST_CASE(FreeVirtualMemory) {
const intptr_t kIterations = 900; // Enough to exhaust 32-bit address space.
for (intptr_t i = 0; i < kIterations; ++i) {
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
- vm->Commit(false);
+ vm->Commit(false, NULL);
delete vm;
}
// Check that truncation does not introduce leaks.
for (intptr_t i = 0; i < kIterations; ++i) {
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
- vm->Commit(false);
+ vm->Commit(false, NULL);
vm->Truncate(kVirtualMemoryBlockSize / 2, true);
delete vm;
}
for (intptr_t i = 0; i < kIterations; ++i) {
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
- vm->Commit(true);
+ vm->Commit(true, NULL);
vm->Truncate(kVirtualMemoryBlockSize / 2, false);
delete vm;
}
for (intptr_t i = 0; i < kIterations; ++i) {
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
- vm->Commit(true);
+ vm->Commit(true, NULL);
vm->Truncate(0, true);
delete vm;
}
for (intptr_t i = 0; i < kIterations; ++i) {
VirtualMemory* vm = VirtualMemory::Reserve(kVirtualMemoryBlockSize);
- vm->Commit(false);
+ vm->Commit(false, NULL);
vm->Truncate(0, false);
delete vm;
}
@@ -96,7 +96,7 @@ VM_UNIT_TEST_CASE(VirtualMemoryCommitPartial) {
// Commit only the middle MB and write to it.
const uword commit_start = vm->start() + (1 * MB);
const intptr_t kCommitSize = 1 * MB;
- vm->Commit(commit_start, kCommitSize, false);
+ vm->Commit(commit_start, kCommitSize, false, NULL);
char* buf = reinterpret_cast<char*>(commit_start);
EXPECT(IsZero(buf, buf + kCommitSize));
buf[0] = 'f';
« no previous file with comments | « runtime/vm/virtual_memory_macos.cc ('k') | runtime/vm/virtual_memory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698