Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: runtime/vm/virtual_memory_fuchsia.cc

Issue 2929203002: [Fuchsia] Give VMOs names (Closed)
Patch Set: Ignore name set failure. Properly select old space Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/virtual_memory_fuchsia.cc
diff --git a/runtime/vm/virtual_memory_fuchsia.cc b/runtime/vm/virtual_memory_fuchsia.cc
index bc708ec8516e588d9ba1a2f2380ef65e93505c82..8c931450ed2136e8744392e9b622d82295c3ed56 100644
--- a/runtime/vm/virtual_memory_fuchsia.cc
+++ b/runtime/vm/virtual_memory_fuchsia.cc
@@ -201,7 +201,10 @@ bool VirtualMemory::FreeSubSegment(int32_t handle,
}
-bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {
+bool VirtualMemory::Commit(uword addr,
+ intptr_t size,
+ bool executable,
+ const char* name) {
ASSERT(Contains(addr));
ASSERT(Contains(addr + size) || (addr + size == end()));
mx_handle_t vmo = MX_HANDLE_INVALID;
@@ -212,6 +215,10 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {
return false;
}
+ if (name != NULL) {
+ mx_object_set_property(vmo, MX_PROP_NAME, name, strlen(name));
+ }
+
mx_handle_t vmar = static_cast<mx_handle_t>(handle());
const size_t offset = addr - start();
const uint32_t flags = MX_VM_FLAG_SPECIFIC | MX_VM_FLAG_PERM_READ |

Powered by Google App Engine
This is Rietveld 408576698