[Fuchsia] Give VMOs names

[Fuchsia] Give VMOs names

This CL assigns names to vmos formatted as "isolate space type" where
isolate is the name of the isolate, space is "oldspace" or "newspace",
and type is "code" or "data".

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/1393e84863a7a2e9604c26793063773eed838fa1

[zra, 2017-06-09 19:19:36]

Description was changed from

==========
[Fuchsia] Give VMOs names
==========

to

==========
[Fuchsia] Give VMOs names

This CL assigns names to vmos formatted as "isolate space type" where
isolate is the name of the isolate, space is "oldspace" or "newspace",
and type is "code" or "data".
==========

[zra, 2017-06-09 19:19:48]

zra@google.com changed reviewers:
+ asiva@google.com

[abarth, 2017-06-09 19:46:38]

abarth@google.com changed reviewers:
+ abarth@google.com

[abarth, 2017-06-09 19:46:41]

https://codereview.chromium.org/2929203002/diff/1/runtime/vm/virtual_memory_f...
File runtime/vm/virtual_memory_fuchsia.cc (right):

https://codereview.chromium.org/2929203002/diff/1/runtime/vm/virtual_memory_f...
runtime/vm/virtual_memory_fuchsia.cc:220: if (status != NO_ERROR) {
The pattern we've been using is to ignore errors on setting the name.

[abarth, 2017-06-09 19:46:58]

Thanks for doing this!

[zra, 2017-06-09 20:10:22]

https://codereview.chromium.org/2929203002/diff/1/runtime/vm/virtual_memory_f...
File runtime/vm/virtual_memory_fuchsia.cc (right):

https://codereview.chromium.org/2929203002/diff/1/runtime/vm/virtual_memory_f...
runtime/vm/virtual_memory_fuchsia.cc:220: if (status != NO_ERROR) {
On 2017/06/09 19:46:40, abarth wrote:
> The pattern we've been using is to ignore errors on setting the name.

Done.

[siva, 2017-06-09 21:25:46]

LGTM with one comment.

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:64: bool is_executable = (type == kExecutable);
Why not make Heap::RegionName a static method and call it here

const intptr_t kVmNameSize = 128;
char vm_name[kVmNameSize];
Heap::RegionName(is_executable ? Heap::kCode : Heap::kOld, vm_name,
kVmNameSize);

instead of the two blobs in PageSpace::AllocatePage and
PageSpace::AllocateLargePage and the additional parameter 'name' being passed in

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/scavenger.cc...
runtime/vm/scavenger.cc:291: const bool kExecutable = false;
Ditto comment about moving the call to Heap::RegionName here.

[zra, 2017-06-09 21:47:36]

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:64: bool is_executable = (type == kExecutable);
On 2017/06/09 21:25:46, siva wrote:
> Why not make Heap::RegionName a static method and call it here
> 
> const intptr_t kVmNameSize = 128;
> char vm_name[kVmNameSize];
> Heap::RegionName(is_executable ? Heap::kCode : Heap::kOld, vm_name,
> kVmNameSize);
> 
> instead of the two blobs in PageSpace::AllocatePage and
> PageSpace::AllocateLargePage and the additional parameter 'name' being passed
in

Same situation here. Have to pass either the name or the Heap to get at the
isolate name (or add a back pointer to HeapPage).

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/2929203002/diff/20001/runtime/vm/scavenger.cc...
runtime/vm/scavenger.cc:291: const bool kExecutable = false;
On 2017/06/09 21:25:46, siva wrote:
> Ditto comment about moving the call to Heap::RegionName here.

VirtualMemory and SemiSpace don't have back pointers to the Heap object to get
the isolate name. I thought it would be simpler to pass the string instead of
passing the Heap or adding back pointers.

[zra, 2017-06-09 22:33:22]

Description was changed from

==========
[Fuchsia] Give VMOs names

This CL assigns names to vmos formatted as "isolate space type" where
isolate is the name of the isolate, space is "oldspace" or "newspace",
and type is "code" or "data".
==========

to

==========
[Fuchsia] Give VMOs names

This CL assigns names to vmos formatted as "isolate space type" where
isolate is the name of the isolate, space is "oldspace" or "newspace",
and type is "code" or "data".

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1393e84863a7a2e9604c26793063773eed838fa1
==========

[zra, 2017-06-09 22:33:23]

Committed patchset #3 (id:40001) manually as
1393e84863a7a2e9604c26793063773eed838fa1 (presubmit successful).