Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: milo/appengine/frontend/main_test.go

Issue 2929173002: Milo: Use UTC representation for commit time in blamelist (Closed)
Patch Set: Also builder Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/frontend/main_test.go
diff --git a/milo/appengine/frontend/main_test.go b/milo/appengine/frontend/main_test.go
index 9c298fbba71145f9e4a70f154772833961503442..a81d3117121f498ffd98b8d9fa36d43b7fff3d6c 100644
--- a/milo/appengine/frontend/main_test.go
+++ b/milo/appengine/frontend/main_test.go
@@ -79,7 +79,7 @@ type analyticsSettings struct {
func TestPages(t *testing.T) {
fixZeroDurationRE := regexp.MustCompile(`(Running for:|waiting) 0s?`)
- _ = func(text string) string {
+ fixZeroDuration := func(text string) string {
return fixZeroDurationRE.ReplaceAllLiteralString(text, "[ZERO DURATION]")
}
@@ -107,10 +107,9 @@ func TestPages(t *testing.T) {
if *generate {
mustWrite(fname, buf)
} else {
- _, err := load(fname)
+ localBuf, err := load(fname)
So(err, ShouldBeNil)
- // TODO(hinoka): Fix and re-enable. crbug/731562.
- // So(fixZeroDuration(string(buf)), ShouldEqual, fixZeroDuration(string(localBuf)))
+ So(fixZeroDuration(string(buf)), ShouldEqual, fixZeroDuration(string(localBuf)))
}
})
}
« no previous file with comments | « milo/appengine/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698