Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1478)

Unified Diff: milo/appengine/buildbot/build_test.go

Issue 2929173002: Milo: Use UTC representation for commit time in blamelist (Closed)
Patch Set: Also builder Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/build.go ('k') | milo/appengine/buildbot/builder.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/build_test.go
diff --git a/milo/appengine/buildbot/build_test.go b/milo/appengine/buildbot/build_test.go
index a580e5c3a635e58a2c737c1f64fc083e68b4c706..1eca5c0d0225c7b163881fe9f57293bcc3dc3dd9 100644
--- a/milo/appengine/buildbot/build_test.go
+++ b/milo/appengine/buildbot/build_test.go
@@ -78,11 +78,10 @@ func TestBuild(t *testing.T) {
for _, tc := range TestCases {
Convey(fmt.Sprintf("Test Case: %s/%s", tc.Builder, tc.Build), func() {
- _, err := Build(c, "debug", tc.Builder, tc.Build)
+ build, err := Build(c, "debug", tc.Builder, tc.Build)
So(err, ShouldBeNil)
- _ = fmt.Sprintf("%s.%d.build.json", tc.Builder, tc.Build)
- // TODO(hinoka): Fix and re-enable. crbug/731562.
- // So(build, shouldMatchExpectationsFor, fname)
+ fname := fmt.Sprintf("%s.%d.build.json", tc.Builder, tc.Build)
+ So(build, shouldMatchExpectationsFor, fname)
})
}
« no previous file with comments | « milo/appengine/buildbot/build.go ('k') | milo/appengine/buildbot/builder.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698