Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/compiler/lib/src/js_emitter/metadata_collector.dart

Issue 2929143002: Handle instance fields in compile_from_dill_test (Closed)
Patch Set: Cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/metadata_collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
index 52ea41b2e10b89616fb34655b8449ea52ded5b97..681626f63fe93ea72e55db86df646d4e3772d374 100644
--- a/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/metadata_collector.dart
@@ -199,13 +199,19 @@ class MetadataCollector implements jsAst.TokenFinalizer {
return _buildMetadataFunction(element);
}
- bool _mustEmitMetadataForMember(MemberElement element) {
- return _mirrorsData.mustRetainMetadata &&
- _mirrorsData.isMemberReferencedFromMirrorSystem(element);
+ bool _mustEmitMetadataForMember(MemberEntity member) {
+ if (!_mirrorsData.mustRetainMetadata) {
+ return false;
+ }
+ // TODO(johnniwinther): Handle member entities.
+ MemberElement element = member;
+ return _mirrorsData.isMemberReferencedFromMirrorSystem(element);
}
- jsAst.Fun buildFieldMetadataFunction(FieldElement element) {
- if (!_mustEmitMetadataForMember(element)) return null;
+ jsAst.Fun buildFieldMetadataFunction(FieldEntity field) {
+ if (!_mustEmitMetadataForMember(field)) return null;
+ // TODO(johnniwinther): Handle field entities.
+ FieldElement element = field;
return _buildMetadataFunction(element);
}

Powered by Google App Engine
This is Rietveld 408576698