Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2929143002: Handle instance fields in compile_from_dill_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -37 lines) Patch
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 5 chunks +19 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 5 chunks +9 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 chunk +11 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 5 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_private_name_inheritance_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-09 16:32:54 UTC) #2
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-09 19:51:48 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-12 07:46:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7bd8cfe670cdb68cd857490ddf5fc98739dfbc7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698