Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: components/payments/content/payment_request.h

Issue 2929133004: Merge-60 [Payments] Record abort reasons on desktop. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | components/payments/content/payment_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/payments/content/payment_request.h
diff --git a/components/payments/content/payment_request.h b/components/payments/content/payment_request.h
index 09c31b1ae08a5fb86ea16d55fc03bd52b899bbc6..e0ab3fa4cd8ce9b87e56e5cab75537f8345800ec 100644
--- a/components/payments/content/payment_request.h
+++ b/components/payments/content/payment_request.h
@@ -99,8 +99,10 @@ class PaymentRequest : public mojom::PaymentRequest,
PaymentRequestState* state() { return state_.get(); }
private:
- void RecordFirstCompletionStatus(
- JourneyLogger::CompletionStatus completion_status);
+ // Only records the abort reason if it's the first completion for this Payment
+ // Request. This is necessary since the aborts cascade into one another with
+ // the first one being the most precise.
+ void RecordFirstAbortReason(JourneyLogger::AbortReason completion_status);
content::WebContents* web_contents_;
std::unique_ptr<PaymentRequestDelegate> delegate_;
@@ -121,7 +123,8 @@ class PaymentRequest : public mojom::PaymentRequest,
JourneyLogger journey_logger_;
- bool has_recorded_abort_reason_ = false;
+ // Whether a completion was already recorded for this Payment Request.
+ bool has_recorded_completion_ = false;
DISALLOW_COPY_AND_ASSIGN(PaymentRequest);
};
« no previous file with comments | « chrome/test/BUILD.gn ('k') | components/payments/content/payment_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698