content/browser/browser_context.cc - Issue 2929113002: Enable spare RenderProcessHost to be preinitialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_context.cc

Issue 2929113002: Enable spare RenderProcessHost to be preinitialized. (Closed)

Patch Set: Change creation of storage partition to not break unittests with subtle threading issues Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_context.cc

diff --git a/content/browser/browser_context.cc b/content/browser/browser_context.cc

index 4330c116c0057041f606df321d828589680d1a02..e57ec6987ccd3b3d54d300986c0b79bb2ae624de 100644

--- a/content/browser/browser_context.cc

+++ b/content/browser/browser_context.cc

@@ -368,8 +368,10 @@ void BrowserContext::NotifyWillBeDestroyed(BrowserContext* browser_context) {

RenderProcessHost::AllHostsIterator();

!host_iterator.IsAtEnd(); host_iterator.Advance()) {

RenderProcessHost* host = host_iterator.GetCurrentValue();

- if (host->GetBrowserContext() == browser_context)

+ if (host->GetBrowserContext() == browser_context) {

+ // This will also clean up spare RPH references.

host->ForceReleaseWorkerRefCounts();

+ }

}