Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: content/public/browser/render_process_host.h

Issue 2929113002: Enable spare RenderProcessHost to be preinitialized. (Closed)
Patch Set: comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index 778f93da8ceffbb9c6fa48d053c098f332289d64..67de6ffeadbcf0cd78a87cecda15c35be4e3e3a9 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -377,6 +377,23 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Static management functions -----------------------------------------------
+ // Possibly start an unbound, spare RenderProcessHost. A subsequent call to
+ // CreateRenderProcessHost with a matching browser_context may use this
Charlie Reis 2017/06/26 21:22:50 This comment makes it sound like any use of Create
mattcary 2017/06/28 13:14:38 Rephrased, as CreateRenderProcessHost is not conte
+ // preinitialized RenderProcessHost, improving performance.
+ //
+ // It is safe to call this multiple times or when it is not certain that the
+ // spare renderer will be used, although calling this too eagerly may reduce
+ // performance as unnecessary RenderProcessHosts are created. The spare
+ // renderer may depend on details of the BrowserContext and will probably not
+ // be used if those details change (for example, the StoragePartition).
Charlie Reis 2017/06/26 21:22:50 Let's rephrase this last bit to avoid "probably."
mattcary 2017/06/28 13:14:38 OK, but my instinct is that those are implementati
+ //
+ // The spare RenderProcessHost is meant to be created in a situation where a
+ // navigation is imminent and it is unlikely an existing RenderProcessHost
+ // will be used, for example in a cross-site navigation when a Service Worker
+ // will need to be started.
+ static void WarmupSpareRenderProcessHost(
+ content::BrowserContext* browser_context);
+
// Flag to run the renderer in process. This is primarily
// for debugging purposes. When running "in process", the
// browser maintains a single RenderProcessHost which communicates

Powered by Google App Engine
This is Rietveld 408576698