Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 2929113002: Enable spare RenderProcessHost to be preinitialized. (Closed)
Patch Set: comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index 96900941e917bf964a13293930b129bb36f9ab78..fbf484898fb2d5581a6b6b0951370e56ef2e73bf 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -114,9 +114,11 @@ class CONTENT_EXPORT RenderProcessHostImpl
public NON_EXPORTED_BASE(mojom::AssociatedInterfaceProvider),
public NON_EXPORTED_BASE(mojom::RendererHost) {
public:
- RenderProcessHostImpl(BrowserContext* browser_context,
- StoragePartitionImpl* storage_partition_impl,
- bool is_for_guests_only);
+ static RenderProcessHost* CreateRenderProcessHost(
+ BrowserContext* browser_context,
+ StoragePartitionImpl* storage_partition_impl,
+ bool is_for_guests_only);
+
~RenderProcessHostImpl() override;
// RenderProcessHost implementation (public portion).
@@ -335,6 +337,14 @@ class CONTENT_EXPORT RenderProcessHostImpl
RenderProcessHost* render_process_host,
const GURL& site_url);
+ // This should be called when the storage partition associated with the
+ // RenderProcessHost is shutdown.
Charlie Reis 2017/06/26 21:22:50 nit: This is a static method, so "associated with
mattcary 2017/06/28 13:14:38 Done.
+ static void OnStoragePartitionShutdown(StoragePartition* partition);
+
+ // Return the spare RenderProcessHost, if it exists. There is at most one
+ // globally-used spare RenderProcessHost at any time.
+ static RenderProcessHost* GetSpareRenderProcessHostForTesting();
+
protected:
// A proxy for our IPC::Channel that lives on the IO thread.
std::unique_ptr<IPC::ChannelProxy> channel_;
@@ -361,6 +371,12 @@ class CONTENT_EXPORT RenderProcessHostImpl
class ConnectionFilterController;
class ConnectionFilterImpl;
+ // Use CreateRenderProcessHost() instead of calling this constructor
+ // directly.
+ RenderProcessHostImpl(BrowserContext* browser_context,
+ StoragePartitionImpl* storage_partition_impl,
+ bool is_for_guests_only);
+
// Initializes a new IPC::ChannelProxy in |channel_|, which will be connected
// to the next child process launched for this host, if any.
void InitializeChannelProxy();

Powered by Google App Engine
This is Rietveld 408576698