Include uriToSource from dill-based libraries in output

Include uriToSource from dill-based libraries in output.

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/2042128817a6a4558b8241831f0a901bac07f266

[Johnni Winther, 2017-06-09 12:04:31]

johnniwinther@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-06-09 12:09:50]

LGTM

Note that "external library" normally has a very specific different meaning in
this context, that is, a package:kernel Library that has isExternal.

Since that's not the kind of external library you're talking about, perhaps
change the CL description, for example:

Include uriToSource from dill-based libraries in output.

[Johnni Winther, 2017-06-09 12:10:57]

Description was changed from

==========
Include sources for external libraries in .dill
==========

to

==========
Include uriToSource from dill-based libraries in output.
==========

[Johnni Winther, 2017-06-09 12:11:52]

Description was changed from

==========
Include uriToSource from dill-based libraries in output.
==========

to

==========
Include uriToSource from dill-based libraries in output.

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2042128817a6a4558b8241831f0a901bac07f266
==========

[Johnni Winther, 2017-06-09 12:11:53]

Committed patchset #1 (id:1) manually as
2042128817a6a4558b8241831f0a901bac07f266 (presubmit successful).

[scheglov, 2017-06-09 15:32:55]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-09 15:32:56]

Could you please describe the problem you're solving?

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_loader.dart (right):

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_loader.dart:19: /// Sources for all
appended programs.
"appended libraries"

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_loader.dart:37:
uriToSource.addAll(program.uriToSource);
We're adding only some libraries, why do we add ALL sources?

[Johnni Winther, 2017-06-09 15:42:04]

On 2017/06/09 15:32:56, scheglov wrote:
> Could you please describe the problem you're solving?
> 
>
https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
> File pkg/front_end/lib/src/fasta/dill/dill_loader.dart (right):
> 
>
https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/dill/dill_loader.dart:19: /// Sources for all
> appended programs.
> "appended libraries"
> 
>
https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
> pkg/front_end/lib/src/fasta/dill/dill_loader.dart:37:
> uriToSource.addAll(program.uriToSource);
> We're adding only some libraries, why do we add ALL sources?

A .dill generated using a pre-generated platform.dill didn't contain sources for
instance for 'Object'. Accessing TreeNode.location generated a range error
because we tried to look up the fileOffset in the fileUri ''.

[Johnni Winther, 2017-06-09 15:46:23]

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_loader.dart (right):

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_loader.dart:37:
uriToSource.addAll(program.uriToSource);
On 2017/06/09 15:32:56, scheglov wrote:
> We're adding only some libraries, why do we add ALL sources?

To ensure soundness. It would of course be an optimization to find only the
needed sources.

[Johnni Winther, 2017-06-09 15:46:23]

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_loader.dart (right):

https://codereview.chromium.org/2929103002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_loader.dart:37:
uriToSource.addAll(program.uriToSource);
On 2017/06/09 15:32:56, scheglov wrote:
> We're adding only some libraries, why do we add ALL sources?

To ensure soundness. It would of course be an optimization to find only the
needed sources.