Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2928993003: Toggle Visibility/Visibility-Off icons when showing/hiding passwords. (Closed)

Created:
3 years, 6 months ago by hcarmona
Modified:
3 years, 6 months ago
Reviewers:
scottchen
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Toggle Visibility/Visibility-Off icons when showing/hiding passwords. R=scottchen@chromium.org BUG=716492 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2928993003 Cr-Commit-Position: refs/heads/master@{#480671} Committed: https://chromium.googlesource.com/chromium/src/+/fedc5e878612f7fbbd0fa87f75cedcdff5b23a42

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A chrome/browser/resources/settings/images/settings_icon_visibility_off.svg View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_icons_css.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
hcarmona
PTAL, I can also rebase this so it's not dependent on your CL
3 years, 6 months ago (2017-06-09 01:12:54 UTC) #4
scottchen
https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html#newcode37 chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:37: margin: 2px; Is the margin necessary on all 4 ...
3 years, 6 months ago (2017-06-09 19:54:21 UTC) #7
hcarmona
https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html#newcode37 chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:37: margin: 2px; On 2017/06/09 19:54:21, scottchen wrote: > Is ...
3 years, 6 months ago (2017-06-12 18:11:14 UTC) #10
scottchen
On 2017/06/12 18:11:14, hcarmona wrote: > https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html > File > chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html > (right): > > ...
3 years, 6 months ago (2017-06-12 23:52:57 UTC) #13
hcarmona
Rebased, take a quick look and I'll commit if it still looks good
3 years, 6 months ago (2017-06-19 23:27:34 UTC) #17
scottchen
On 2017/06/19 23:27:34, hcarmona wrote: > Rebased, take a quick look and I'll commit if ...
3 years, 6 months ago (2017-06-20 00:46:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928993003/60001
3 years, 6 months ago (2017-06-20 01:04:51 UTC) #23
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 01:09:48 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fedc5e878612f7fbbd0fa87f75ce...

Powered by Google App Engine
This is Rietveld 408576698