|
|
Created:
3 years, 6 months ago by hcarmona Modified:
3 years, 6 months ago Reviewers:
scottchen CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, gcasto+watchlist_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionToggle Visibility/Visibility-Off icons when showing/hiding passwords.
R=scottchen@chromium.org
BUG=716492
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2928993003
Cr-Commit-Position: refs/heads/master@{#480671}
Committed: https://chromium.googlesource.com/chromium/src/+/fedc5e878612f7fbbd0fa87f75cedcdff5b23a42
Patch Set 1 #
Total comments: 4
Patch Set 2 : feedback #Patch Set 3 : rebase #
Messages
Total messages: 26 (18 generated)
Description was changed from ========== Toggle Visibility/Visibility-Off icons when showing/hiding passwords. R=scottchen@chromium.org BUG=716492 ========== to ========== Toggle Visibility/Visibility-Off icons when showing/hiding passwords. R=scottchen@chromium.org BUG=716492 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL, I can also rebase this so it's not dependent on your CL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:37: margin: 2px; Is the margin necessary on all 4 sides? https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_icons_css.html:10: background-size: 24px; I remember you mentioned something about this. Were you able to figure out why this is necessary even though the svg already has width/height: 24?
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:37: margin: 2px; On 2017/06/09 19:54:21, scottchen wrote: > Is the margin necessary on all 4 sides? no, only start. Updated. https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_icons_css.html (right): https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_icons_css.html:10: background-size: 24px; On 2017/06/09 19:54:21, scottchen wrote: > I remember you mentioned something about this. Were you able to figure out why > this is necessary even though the svg already has width/height: 24? https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_va... --cr-icon-size is 20px, but these icons need to be 24px. This dialog is the exception, so I'll move this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/06/12 18:11:14, hcarmona wrote: > https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... > File > chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html > (right): > > https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html:37: > margin: 2px; > On 2017/06/09 19:54:21, scottchen wrote: > > Is the margin necessary on all 4 sides? > > no, only start. Updated. > > https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/settings_icons_css.html (right): > > https://codereview.chromium.org/2928993003/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/settings_icons_css.html:10: background-size: > 24px; > On 2017/06/09 19:54:21, scottchen wrote: > > I remember you mentioned something about this. Were you able to figure out why > > this is necessary even though the svg already has width/height: 24? > > https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_va... > > --cr-icon-size is 20px, but these icons need to be 24px. > > This dialog is the exception, so I'll move this. LGTM, but FYI I'm trying to land this too: https://codereview.chromium.org/2848973003/, not sure which one's going to land first.
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Rebased, take a quick look and I'll commit if it still looks good
On 2017/06/19 23:27:34, hcarmona wrote: > Rebased, take a quick look and I'll commit if it still looks good Still LG, thanks for moving the image to settings/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hcarmona@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottchen@chromium.org Link to the patchset: https://codereview.chromium.org/2928993003/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497920656481500, "parent_rev": "e37d8b333cfeac144ffba93ccb251c277b1680b3", "commit_rev": "fedc5e878612f7fbbd0fa87f75cedcdff5b23a42"}
Message was sent while issue was closed.
Description was changed from ========== Toggle Visibility/Visibility-Off icons when showing/hiding passwords. R=scottchen@chromium.org BUG=716492 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Toggle Visibility/Visibility-Off icons when showing/hiding passwords. R=scottchen@chromium.org BUG=716492 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2928993003 Cr-Commit-Position: refs/heads/master@{#480671} Committed: https://chromium.googlesource.com/chromium/src/+/fedc5e878612f7fbbd0fa87f75ce... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/fedc5e878612f7fbbd0fa87f75ce... |