third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js - Issue 2928833002: [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

Issue 2928833002: [CacheStorage] [DevTools] Added "Time Received" column to cache storage data grid (Closed)

Patch Set: Removed Time.h changes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-data.html ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

index d3e9354170efb8c9caead69491ae320ae5038008..14e1e6e52b5aa0eb25fb90df4643d88822575c9c 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js

@@ -39,7 +39,11 @@ InspectorTest.dumpCacheTree = async function()

}

var dataGrid = view._dataGrid;

for (var node of dataGrid.rootNode().children) {

- var entries = Array.from(node.element().children, td => td.textContent).filter(text => text);

+ var children = Array.from(node.element().children).filter(function (element) {

+ // Removes timestamp, potential flake depending on time zone

+ return !(element.classList.contains("responseTime-column"));

+ });

+ var entries = Array.from(children, td => td.textContent).filter(text => text);

InspectorTest.addResult(" " + entries.join(", "));

}